Permit easily purging unmanaged repos #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 2, 2022
bastelfreak
approved these changes
Jul 2, 2022
|
Can you release a new forge version with the last batch of changes? |
|
@jcpunk does this actually work? If I just create a purge file resource for the directory, the module creates the repos and then purges them again each run. Apparently the modules creates files without using the file resources. |
That is from one run. |
|
I'm a bit surprised that the My target use case is paired with voxpupuli/puppet-rhsm@1c2abe5 so that I can be sure only |
|
I've popped open https://tickets.puppetlabs.com/browse/PUP-11585 (I can't seem to create tickets against the MODULE project....) |
This was referenced Dec 6, 2022
|
This was an attempted fix of #94. |
kenyon
added a commit
to kenyon/puppet-yum
that referenced
this pull request
Dec 7, 2022
This method of purging unmanaged yum repo configs does not work. Fixes voxpupuli#285
kenyon
added a commit
that referenced
this pull request
Dec 9, 2022
Revert #258, which added purge_unmanaged_repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
With the support for defining repos, it is helpful to have an easy way to purge unmanaged repos.
This Pull Request (PR) fixes the following issues
N/A