-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module data for EPEL #44
Conversation
|
Do you need anything else for this? |
|
Hi @lamawithonel, thanks for the pullrequest. Can you please add some spec tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, the documentation doesn not list a managed_yumrepos param, the github search function does not find managed_yumrepos . Did you mean managed_repos? If yes, please fixup commit message and PR text.
Can you show some example puppet code how one is supposed to use it?
If anybody wants to use this managed_yumrepos feature but not the default repos. how is one supposed to ignore the module provided data?
What happens for a user already using managed_repos? does one get automatically EPEL too?
I think the docs could benefit if there were some examples.
f010a7e
to
033c595
Compare
|
@lamawithonel I think it would be useful to have a few spec tests that exercise this new data... At a minimum there needs to be a test that sets managed_repos to use the repos from that list, and asserts that it does not fail with type errors or otherwise. |
This adds the data required to enable EPEL via the `managed_repos` parameter.
|
Tests were added. Do you need anything else? |
|
Are all of these new changes going to be pushed to Puppet Forge as a new release any time soon? There seems to be a lot of additional functionality at this point. If there is any way I can help, let me know. Thanks. |
This adds the data required to enable EPEL via the
managed_yumreposparameter.