Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server and Proxy templates are inconsistent #144

Closed
Moncky opened this issue Jan 4, 2016 · 3 comments
Closed

Server and Proxy templates are inconsistent #144

Moncky opened this issue Jan 4, 2016 · 3 comments
Labels
bug
Milestone

Comments

@Moncky
Copy link

@Moncky Moncky commented Jan 4, 2016

The Server and Proxy templates are inconsistent where applying memory limits to caches

For example the CacheSize option on the Server is:

CacheSize=<%= @cachesize %>

whilst on the Proxy is:

CacheSize=<%= @cachesize -%>M

Ideally this should be one or the other so that the puppet code is also then written consistently

@dj-wasabi dj-wasabi added the bug label Jan 8, 2016
@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

@dj-wasabi dj-wasabi commented Jan 8, 2016

Hi @Moncky
You are right. Will fix it.

Thank you for mentioning!

Kind regards,
Werner

@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

@dj-wasabi dj-wasabi commented Jan 8, 2016

I pushed an fix.
< edit>
Will be in release 2.0.0
</ edit>

@dj-wasabi dj-wasabi added this to the 2.0.0 milestone Jan 28, 2016
@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

@dj-wasabi dj-wasabi commented Feb 1, 2016

Released yesterday on the Forge.

@dj-wasabi dj-wasabi closed this Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.