pg_hba problems in zabbix::database

[RaphaelNeumann]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.9.2
• Ruby: 2.0.0p648 (2015-12-16) [x86_64-linux]
• Distribution: Rhel7
• Module version: 4.1.0

How to reproduce (e.g Puppet code you use)

node 'zabbix.srv' {
  class { 'apache':
    mpm_module => 'prefork',
  }

  class { 'apache::mod::php': }
  
  class { 'zabbix::web':
    manage_repo   => false,
    zabbix_url    => 'zabbix.local',
    zabbix_server => '192.168.100.55',
    database_host => '192.168.100.50',
    database_type =>'postgres',
  }
  
  class { 'postgresql::client': }

  class { 'zabbix::server':
    manage_repo   => false,
    database_host  => '192.168.100.50',
    database_type  => 'postgres'
  }
}

node 'postgres.srv' {
  class { 'postgresql::server':
    listen_addresses => '192.168.10.50'
  }

  class { 'zabbix::database':
	  database_type    => 'postgres'
	  zabbix_web_ip    => '192.168.100.55,
	  zabbix_server_ip => '192.168.100.55'
  }
}

What are you seeing

When the zabbix_server and zabbix_web are at the same server but the database are on another this module don't create a pg_hba rule for zabbix_server/zabbix_web

What behaviour did you expect instead

I expect the zabbix_database class was create a zabbix database and create a pg_hba rule for zabbix_server

Output log

Info: Using configured environment 'zabbix'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for renegade.detran.df
Info: Applying configuration version '1497997556'
Notice: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_create.sql]/returns: psql: FATAL: no pg_hba.conf entry for host "10.138.100.143", user "zabbix_server", database "zabbix_server", SSL off
Error: cd /usr/share/doc/zabbix--pgsql-3.2/ && if [ -f create.sql.gz ]; then gunzip -f create.sql.gz ; fi && psql -h '10.138.100.23' -U 'zabbix_server' -d 'zabbix_server' -f create.sql && touch /etc/zabbix/.schema.done returned 2 instead of one of [0]
Error: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_create.sql]/returns: change from notrun to 0 failed: cd /usr/share/doc/zabbix--pgsql-3.2/ && if [ -f create.sql.gz ]; then gunzip -f create.sql.gz ; fi && psql -h '10.138.100.23' -U 'zabbix_server' -d 'zabbix_server' -f create.sql && touch /etc/zabbix/.schema.done returned 2 instead of one of [0]
Notice: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_images.sql]: Dependency Exec[zabbix_server_create.sql] has failures: true
Warning: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_images.sql]: Skipping because of failed dependencies
Notice: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_data.sql]: Dependency Exec[zabbix_server_create.sql] has failures: true
Warning: /Stage[main]/Zabbix::Database::Postgresql/Exec[zabbix_server_data.sql]: Skipping because of failed dependencies

Any additional information you'd like to impart

I Will try to fix it with a pullrequest :D