New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI setup: ensure all rspec tests pass #162

Merged
merged 1 commit into from Feb 2, 2016

Conversation

Projects
None yet
2 participants
@rnelson0
Copy link
Member

rnelson0 commented Feb 2, 2016

This is an update to the Travis CI configuration and a rewrite of all rspec tests that standardizes them using the same layout. It also includes the fixes to the code required to get the rspec tests to pass with Puppet 3 and 4.

It does remove Puppet 2.7 from the test matrix. 2.7 is no longer supported and rspec generates a ton of failures that cannot be fixed without massive rewrites to the code. I believe this is fine, but it is up to you to accept it or not.

Fixes #160

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 2, 2016

Working on making this pass Travis CI. Seeing lint problems I did not observe locally now.

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 2, 2016

@dj-wasabi This is ready for review now. I've used it to deploy my simple AIO zabbix server, so I know that the rspec test changes aren't affecting single node installations at least, and of course rspec tests themselves are passing. I did a little reformating to make the tests run faster but there is no net change in number of tests, just how they're grouped.

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 2, 2016

With this and #163, a new version should be cut. As described above there should be no effective changes but it may be safer to go to 2.1.0 instead of 2.0.1 just in case...

dj-wasabi added a commit that referenced this pull request Feb 2, 2016

Merge pull request #162 from rnelson0/rspec
Travis CI setup: ensure all rspec tests pass

@dj-wasabi dj-wasabi merged commit 64f93b2 into voxpupuli:master Feb 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

dj-wasabi commented Feb 2, 2016

Many thanks for this! 👍

@dj-wasabi dj-wasabi added this to the 2.1.0 milestone Feb 2, 2016

@rnelson0 rnelson0 deleted the rnelson0:rspec branch Apr 8, 2016

@rnelson0 rnelson0 restored the rnelson0:rspec branch Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment