Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulesync 0.12.2 + Improvements #268

Merged
merged 12 commits into from Aug 27, 2016
Merged

modulesync 0.12.2 + Improvements #268

merged 12 commits into from Aug 27, 2016

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak changed the title modulesync 0.12.2 modulesync 0.12.2 + Improvements Aug 20, 2016
@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Aug 20, 2016
@bastelfreak
Copy link
Member Author

bastelfreak commented Aug 20, 2016

this file was introduced after Werner moved the module to Vox Pupuli.
Proof:
a41669a
this is an approch to fix the issues from:
#267
#266

we workaround the wrong scoping by adding suitable params. We validate
each of them in the defined resource.
@bastelfreak bastelfreak added the needs-feedback Further information is requested label Aug 21, 2016
@daenney
Copy link
Member

daenney commented Aug 21, 2016

This is too many changes in one go, which makes it really hard to follow in a PR. I would suggest you split out the improvement and the modulesync and raise them as PRs in that order.

@bastelfreak bastelfreak mentioned this pull request Aug 21, 2016
@jyaworski
Copy link
Member

This is good. The improvement is very minor, then rubocop stuff.

@jyaworski jyaworski merged commit fae91e7 into master Aug 27, 2016
@jyaworski jyaworski deleted the modulesync branch August 27, 2016 15:23
@bastelfreak bastelfreak added enhancement New feature or request and removed needs-feedback Further information is requested needs-work not ready to merge just yet labels Feb 12, 2017
@bastelfreak bastelfreak self-assigned this Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants