use soapAction from WSDL #100

Merged
merged 1 commit into from Oct 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

yuriykashin commented Oct 12, 2012

I think it's better to use soapAction defined in WSDL, rather than client assumption of its value. Especially since we have it in method.soapAction. And double quote it.

0x80 commented Oct 16, 2012

Yes please. I am calling a java cxf soap server and in a recent update it requires the soap action to be either "" or the name of the method. The wsdl declares soapAction="" but the node client automatically converts it to the namespace + methodname. I would like it to use the "" as defined by the wsdl, because currently cfx doesn't accept the header.

Collaborator

milewise commented Oct 17, 2012

thanks. i'll merge this in and fallback to the previous code if method.soapAction is undefined.

milewise added a commit that referenced this pull request Oct 17, 2012

@milewise milewise merged commit 4a3b5c5 into vpulim:master Oct 17, 2012

0x80 commented Oct 17, 2012

If you specify an empty string as the soapAction in the wsdl, which is what you do when you want the soapAction to stay empty, it will be "undefined" as well so I don't know how that would work.

diarmaidm pushed a commit to diarmaidm/node-soap that referenced this pull request Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment