Namespace should propagate to child nodes and clean up of unused code #74

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@cjblomqvist

I assume it's a bug (I'm unfortunately not that well versed with SOAP to know for sure but it caused my script to not work anyway) that the namespace didn't follow through to child nodes. This pull request fixes that issue. I also noticed some weird code that never gets triggered, which I removed (I assume there ain't no long term purpose of it?).

cjblomqvist added some commits Aug 24, 2012
@cjblomqvist cjblomqvist Namespace should be kept for child nodes 1d8844a
@cjblomqvist cjblomqvist Remove unused xmlns attribute
false ? 'something that will never happen : 'something else' doesn't
make sense
e4dbf26
@cjblomqvist

Actually, when I checked the various other pull requests, my pull requests seems to be a "duplicate" of #12 which unfortunately now most likely is too old to pull in.

@sxh2000251

I met the same problem(Namespace is not propagated to child nodes) also, after spending for a whole afternoon to debug the issue, i found the same solution with cjblomqvist.

@ghost
ghost commented Dec 27, 2012

I had a problem with the EU VAT Validation service, this patch fixed it, thanks for the fix!!

@bmorgan21

this seems like a simple change, can we please get this merged back in?

@aheckmann
Collaborator

Closing due to it being unmergeable and missing tests. Please reopen after a rebase and tests are added. Thank you.

@aheckmann aheckmann closed this Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment