Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added composer.json with foglcz/adminer-installer for interactive install #22

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

foglcz commented Aug 3, 2012

Updated adminer to support installation via composer. If merged & added to packagist.org, people can install adminer via composer.json file:

"require" : {
    "vrana/adminer": "3.*"
}

It uses separate type with interactive command-line installer:

Není to zbytečný? Nešlo by ten hook udělat přímo v admineru?

foglcz commented Aug 3, 2012

do not merge. hook je lepsi napad.

@foglcz foglcz closed this Aug 3, 2012

Contributor

halilim commented Mar 23, 2013

I was searching for Composer support for Adminer and have seen this. It looks like the idea is dismissed. Can you guys provide reasons (in English, please :)) and any update on this?

foglcz commented Mar 24, 2013

Well, that's a good question. Mainly because of lack of time & focus, really.
The solution which I did was via separate composer installer - while the proposal was to do it via composer hook (obviously; there's one repository required for the installer, while all this can be done within the repo itself.)

However, the code still exists ( https://github.com/foglcz/adminer-installer/blob/master/foglcz/Adminer/Installer.php ). It's been nine months now, should probably take it further and finish this thing.

The main reason, why it's not so-much-pain-in-the-ass for us is, that we have adminer bundled within Nette framework which we are using ( github.com/nette/sandbox ). However, provided that this feature would be finished, we could then add adminer to the main composer.json file and have it installed during dependencies installation.

Should there be special configuration variable within composer.json, it could also be unattended.
Hope to look into it soon; but can't make any promises..

Contributor

halilim commented Mar 24, 2013

Thanks, I'll be looking forward to it, and would like to provide any help if there is something I can do. Since the compiled size of Adminer is quite small, it's not a problem to include the file using the traditional ways but Composer support would be even better with much easier updates etc. and with an already existing vendor/ .gitignore rule in the including project.

@RobLoach RobLoach referenced this pull request Oct 17, 2014

Closed

Add Composer support #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment