Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Generated columns and virtual columns in Mysql broke editing and adding rows #359

Closed
wants to merge 3 commits into from

Conversation

@malteriesch
Copy link
Contributor

commented Aug 16, 2019

No description provided.

@vrana

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2019

Thanks, merged.

@vrana vrana closed this Aug 19, 2019

@@ -555,6 +555,7 @@ function fields($table) {
"privileges" => array_flip(preg_split('~, *~', $row["Privileges"])),
"comment" => $row["Comment"],
"primary" => ($row["Key"] == "PRI"),
"generated" => in_array($row["Extra"], array("STORED GENERATED", "VIRTUAL GENERATED"))

This comment has been minimized.

Copy link
@vrana

vrana Aug 19, 2019

Owner

https://dev.mysql.com/doc/refman/8.0/en/show-columns.html says that this could be either VIRTUAL GENERATED or VIRTUAL STORED. Is the documentation wrong or is your code wrong?

This comment has been minimized.

Copy link
@malteriesch

malteriesch Aug 20, 2019

Author Contributor

Now, that is interesting! It seems the documentation might be wrong, just tried again both a virtual and stored generated column on a mysql 8.0.16 server and "STORED GENERATED", "VIRTUAL GENERATED" is indeed what I got respectively for "SHOW FULL COLUMNS FROM

"

This comment has been minimized.

Copy link
@vrana

vrana Aug 21, 2019

Owner

Please report a doc bug at https://bugs.mysql.com/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.