Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Sporadic "Argument cannot be null" errors #51

Closed
Cito opened this Issue Mar 25, 2012 · 4 comments

Comments

Projects
None yet
2 participants

Cito commented Mar 25, 2012

I'm sporadically experiencing "Argument cannot be null" error messages with Vrapper 0.19.20120323. The errors happen when I open a new editor with Vrapper disabled.

The log file has stack traces like these:

!ENTRY org.eclipse.ui.workbench 4 2 2012-03-25 13:03:09.129
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui.workbench".
!STACK 0
java.lang.IllegalArgumentException: Argument cannot be null
    at org.eclipse.swt.SWT.error(SWT.java:4263)
    at org.eclipse.swt.SWT.error(SWT.java:4197)
    at org.eclipse.swt.SWT.error(SWT.java:4168)
    at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
    at org.eclipse.swt.widgets.Text.setText(Text.java:1967)
    at net.sourceforge.vrapper.eclipse.ui.ModeContributionItem.fill(ModeContributionItem.java:48)
    at org.eclipse.jface.action.SubContributionItem.fill(SubContributionItem.java:59)
    at org.eclipse.jface.action.StatusLineManager.update(StatusLineManager.java:326)
    at org.eclipse.jface.action.SubStatusLineManager.update(SubStatusLineManager.java:152)
    at net.sourceforge.vrapper.eclipse.ui.ModeContributionItem.setText(ModeContributionItem.java:55)
    at net.sourceforge.vrapper.eclipse.platform.EclipseUserInterfaceService$PartChangeListener.partActivated(EclipseUserInterfaceService.java:66)
    at org.eclipse.ui.internal.PartListenerList$1.run(PartListenerList.java:72)
    ...
    at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

!ENTRY org.eclipse.jface 4 2 2012-03-25 13:03:11.086
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.IllegalArgumentException: Argument cannot be null
    at org.eclipse.swt.SWT.error(SWT.java:4263)
    at org.eclipse.swt.SWT.error(SWT.java:4197)
    at org.eclipse.swt.SWT.error(SWT.java:4168)
    at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
    at org.eclipse.swt.widgets.Text.setText(Text.java:1967)
    at net.sourceforge.vrapper.eclipse.ui.ModeContributionItem.fill(ModeContributionItem.java:48)
    at org.eclipse.jface.action.SubContributionItem.fill(SubContributionItem.java:59)
    ...
    at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Contributor

keforbes commented Mar 27, 2012

Fixed. The current mode name wasn't being initialized if a new file was opened while vrapper was disabled. I now default to 'vrapper disabled', which is the message used when vrapper is toggled.

@keforbes keforbes closed this Mar 27, 2012

Contributor

keforbes commented Mar 27, 2012

By the way, good catch! Thank you for finding this defect!

Contributor

keforbes commented Mar 27, 2012

I've updated the unstable update site (0.19.20120326) to include this fix and the fix for the default register from #50.

Cito commented Mar 27, 2012

Thanks a lot. I have updated to 0.19.20120326 and it works nicely now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment