Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string composite assignment #29

Merged

Conversation

ureishi
Copy link

@ureishi ureishi commented Apr 25, 2022

Fixes an issue where compound assignments containing strings cause an error at runtime.
Call string.Concat if either the left or right side is something other than string.
Convert the right side to string in advance if that is other than string and is a constant.

Fixes an issue where compound assignments containing strings cause an error at runtime.
Call string.Concat if either the left or right side is something other than string.
Convert it to string in advance if the right side is other than string and is a constant.
@MerlinVR MerlinVR merged commit baaa203 into vrchat-community:master Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
@ureishi ureishi deleted the fix-string-composite-assignment branch December 11, 2022 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants