Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image loader update #96

Merged
merged 2 commits into from Feb 22, 2023
Merged

Image loader update #96

merged 2 commits into from Feb 22, 2023

Conversation

Arne-van-der-Lei
Copy link

Added image loading and string loading Functions

momo-the-monster
momo-the-monster approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@momo-the-monster momo-the-monster left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! We'll need to hold on merging this until after SDK 3.1.11 is released, though (this code depends on types not included in 3.1.10).

@momo-the-monster momo-the-monster merged commit 3039c86 into master Feb 22, 2023
@momo-the-monster momo-the-monster deleted the ImageLoaderUpdate branch February 22, 2023 21:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@momo-the-monster momo-the-monster momo-the-monster approved these changes

@MerlinVR MerlinVR Awaiting requested review from MerlinVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arne-van-der-Lei @momo-the-monster