Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VCC 2.0 cannot set the path to Unity editor #121

Closed
Panrium opened this issue Mar 10, 2023 · 3 comments
Closed

[BUG] VCC 2.0 cannot set the path to Unity editor #121

Panrium opened this issue Mar 10, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Panrium
Copy link

Panrium commented Mar 10, 2023

Describe the bug
It shows "Cannot read empty file from "C:\Users\Administrator\AppData\Local\VRChatCreatorCompanion\settings.json" each time I wanted to set a path for unity editor

To Reproduce

  1. In the project panel, it says "Path to a Unity Editor is not set, you will be unable to open projects."

  2. Click on 'fix now', it displays
    image

  3. Selected "I already have Unity", and set the correct path to my editor, which was D:\2019.4.31f1\Editor\unity.exe

  4. an error notification came up:
    Cannot read empty file from "C:\Users\Administrator\AppData\Local\VRChatCreatorCompanion\settings.json"
    image

then the program freezes.

  1. I went to look for the settings.json file, found out that it is a 0kb file and it shows nothing when I open it with notepad.
    image

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Version 21H2

Additional context
I've met similar problem with version 1.6 previously, dunno if it helps

@Faxmashine Faxmashine added the bug Something isn't working label Mar 28, 2023
@KhopeshActual KhopeshActual added this to the 2.1.1 milestone Apr 13, 2023
@momo-the-monster
Copy link
Contributor

We will create a new Settings file if the current one is empty.

@orels1
Copy link
Contributor

orels1 commented Apr 13, 2023

Something else worth exploring: if the file fails to deserialize (reported by testers), like if some values became null that shouldn't be null, we should maybe open a little window like:

Settings file appears to be corrupted, VCC can make a fresh settings file so it can launch correctly. The current settings will be saved as settings-old.json

With 2 buttons: "Create New Settings" and "Close VCC" to back off.

That way users can at least natively reinitialize and then submit the broken settings file to us / manually inspect it

@orels1 orels1 self-assigned this Apr 20, 2023
@orels1
Copy link
Contributor

orels1 commented Apr 21, 2023

VCC now automatically clears and re-creates 0-byte settings files and also provides a special experience for settings files that contain malformed json

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants