Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VCC window is not activated when we click add-repo URL if VCC is running. #235

Closed
Sayamame-beans opened this issue Apr 7, 2023 · 1 comment
Assignees
Milestone

Comments

@Sayamame-beans
Copy link

Describe the bug
VCC window is not activated when we click add-repo URL if VCC is running.
If VCC is not running, the URL work as expected as in this video.

To Reproduce
Steps to reproduce the behavior:

  1. Open VCC
  2. access anatawa12's add-repo URL*

*this URL redirects to vcc://vpm/addRepo?url=https%3A%2F%2Fvpm.anatawa12.com%2Fvpm.json

Expected behavior
When click add-repo URL, VCC window will be activated.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10 Pro 64bit
  • Version 22H2

Additional context
GitHub's markdown does not support links that do not start with http ( github/markup#933 ), so several people are handling this by redirecting.

@momo-the-monster
Copy link
Contributor

From QA:

NEEDS-WORK Even off the installer link "Add to VCC" does not always bring it to front. Potential repro:

  1. Hit 'Add to VCC', observe popup but do not interact. Minimize window
  2. Hit 'Add to VCC again, no popup this time (one already exists?)
  3. Maximize VCC, cancel popup, minimize
  4. Hit 'Add to VCC', still no window maximize, but the popup does happen and you can see it if you manually maximize.

Not 100 on those repro steps, but if you just try using the button a bunch in a row under different conditions you should hit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants