Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG 2.1.0] VCC fails to import a VPM asset (vauge error output) #240

Closed
techanon opened this issue Apr 10, 2023 · 6 comments
Closed

[BUG 2.1.0] VCC fails to import a VPM asset (vauge error output) #240

techanon opened this issue Apr 10, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@techanon
Copy link

techanon commented Apr 10, 2023

Describe the bug
VCC is failing to import an asset. It spits out some un-specific error.

To Reproduce
Steps to reproduce the behavior:

  1. https://vpm.techanon.dev and add to VCC (requires pre-release)
  2. Attempt to add to a project
  3. Check the logs for errors

Expected behavior
The package should succeed on importing.

Screenshots
The logs spits out twice One or more errors occurred. (Object reference not set to an instance of an object.)
image

@techanon techanon changed the title [BUG 2.1.0] VCC fails to import a VPM asset when legacyFolder is present with a GUID [BUG 2.1.0] VCC fails to import a VPM asset (vauge error output) Apr 10, 2023
@techanon
Copy link
Author

Originally thought it was tied to legacy folders, but I removed that entire part from the json and still failing in the same way. Continuing to test things.

@orels1
Copy link
Contributor

orels1 commented Apr 10, 2023

Gitlab doesn't supply a Content-Disposition: attachment header, which is what the VCC is checking for, which is probably unnecessary.

This currently causes your package to fail to download

@techanon
Copy link
Author

Appears so yes. In the mean time I found an alternative gitlab API to upload to which does appear to provide the requisite headers as I am able to import properly now. Thank you for the heads up on that.

@esperecyan
Copy link

Because it does not return content-disposition, GitHub Pages cannot also be used.

@momo-the-monster momo-the-monster added this to the 2.1.2 Release milestone Jun 2, 2023
@KhopeshActual KhopeshActual added the bug Something isn't working label Jun 14, 2023
@momo-the-monster
Copy link
Contributor

@momo-the-monster
Copy link
Contributor

Should be fixed in VCC 2.1.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants