Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPM should warn when other packages will be changed #247

Closed
KhopeshActual opened this issue Apr 13, 2023 · 3 comments
Closed

VPM should warn when other packages will be changed #247

KhopeshActual opened this issue Apr 13, 2023 · 3 comments
Assignees
@orels1
Labels
enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI vpm-core Issues related to the vpm-core
Milestone
2.1.1

Comments

@KhopeshActual
Copy link

KhopeshActual commented Apr 13, 2023 •
edited by orels1

  • Warn people when installing packages if there are dependencies that will be changed
  • Flag for confirming if operations are safe
@KhopeshActual KhopeshActual added this to the 2.1.1 milestone Apr 13, 2023
@orels1
Copy link
Contributor

orels1 commented Apr 17, 2023

Current WIP of this:

Image

If there are major upgrades - it will look like this instead:

Image

I still need to double-check if we properly validate if the package will try to upgrade dependencies in a way that makes them incompatible with other packages in the manifest to determine how deep the warnings should go

@orels1 orels1 added enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI vpm-core Issues related to the vpm-core labels Apr 18, 2023
@orels1
Copy link
Contributor

orels1 commented Apr 18, 2023

Added reporting of the conflicting versions

Image

@anatawa12 anatawa12 mentioned this issue May 4, 2023
Closed
@Happyrobot33
Copy link
Contributor

Added reporting of the conflicting versions

Image

if you click confirm, does this bump all the dependencies then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orels1 orels1

Labels
enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI vpm-core Issues related to the vpm-core
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
3 participants
@orels1 @Happyrobot33 @KhopeshActual