Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] removing legacyFiles is not working if legacyFolders is not specified #299

Closed
anatawa12 opened this issue May 21, 2023 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@anatawa12
Copy link
Contributor

Describe the bug

removing legacyFiles is not working if legacyFolders is not specified

To Reproduce

  1. Add https://anatawa12.github.io/vpm-repo-for-vcc-bug-testing/ to your VCC
  2. Download and add this project to VCC
  3. Open the project with VCC
  4. Add Legacy File with Name or Legacy File With Path

Expected behavior

Assets/legacyFileWithName.txt or Assets/legacyFileWithPath.txt should be removed

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.1

OS

Windows 11

Additional context

There are no logs like Looking for Legacy Packages to Upgrade by Scanning Folders within <package> when we're installing Legacy File with Name or Legacy File With Path

If we added legacyFolders attribute, Looking for Legacy Packages to Upgrade by Scanning Folders within <package> is shown but because of #281, no files are removed. (you can test with legacyFiles with Name with legacyFolders package from same repository)

@anatawa12 anatawa12 added the bug Something isn't working label May 21, 2023
@anatawa12
Copy link
Contributor Author

I confirmed this issue still exists in 2.1.2

@momo-the-monster momo-the-monster self-assigned this Sep 12, 2023
@momo-the-monster
Copy link
Contributor

Thanks! This should be fixed in the next release.

@anatawa12
Copy link
Contributor Author

I confirmed this still is a issue in VCC 2.2.2....

@momo-the-monster
Copy link
Contributor

momo-the-monster commented Dec 14, 2023 via email

@anatawa12
Copy link
Contributor Author

bump. this is still a issue in VCC 2.2.5.

@orels1
Copy link
Contributor

orels1 commented Mar 21, 2024

This should be addressed in the 2.3.0 open beta: https://github.com/vrchat-community/creator-companion/releases/tag/2.3.0

@orels1 orels1 closed this as completed Mar 21, 2024
@orels1
Copy link
Contributor

orels1 commented May 9, 2024

This has been released to live with version 2.3.0: https://vrcpm.vrchat.cloud/vcc/Builds/2.3.0/VRChat_CreatorCompanion_Setup_2.3.0.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants