Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] legacy packages is not working if upgraded by dependencies of other packages #349

Closed
anatawa12 opened this issue Sep 20, 2023 · 3 comments
Closed

[BUG] legacy packages is not working if upgraded by dependencies of other packages #349

anatawa12 opened this issue Sep 20, 2023 · 3 comments
Assignees
@momo-the-monster
Labels
bug Something isn't working

Comments

@anatawa12
Copy link
Contributor

anatawa12 commented Sep 20, 2023 •
edited

Describe the bug

legacy packages is not working if upgraded by dependencies of other packages.

If VRCSDK Worlds is upgraded by dependencies of other packages, UdonSharp and ClientShim are not removed.

To Reproduce

  1. Create Project with VRCSDK Worlds 3.3.0 and UdonSharp
  2. Install packages depends on com.vrchat.worlds 3.4.0-beta.1 or later
    You can use The Package depends on SDK Worlds 3.4.0 in https://anatawa12.github.io/vpm-repo-for-vcc-bug-testing/ for testing.

Actual Behavior
UdonSharp is NOT removed from the project.

Expected behavior

UdonSharp is removed from the project.

Screenshots

Screenshot 2023-09-20 at 16 15 26

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.3

OS

Windows 11

Additional context

This will break unity project so I think this must be fixed BEFORE VRChat SDK 3.4.0 release

Relates to #350
@anatawa12 anatawa12 added the bug Something isn't working label Sep 20, 2023
@anatawa12 anatawa12 changed the title [BUG] legacy folders is not working if upgraded by dependencies of other packages [BUG] legacy packages is not working if upgraded by dependencies of other packages Sep 20, 2023
@anatawa12
Copy link
Contributor Author

Sorry, I made a mistake with the title. This issue is about legacy packages, not about legacy folders.

There are another issue about legacy folders: #298

@anatawa12 anatawa12 mentioned this issue Sep 20, 2023
Closed
@momo-the-monster
Copy link
Contributor

Thanks - working on a fix along with #350.

@momo-the-monster momo-the-monster self-assigned this Sep 20, 2023
@momo-the-monster
Copy link
Contributor

Fixed in VCC 2.1.4.

@anatawa12 anatawa12 mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@momo-the-monster momo-the-monster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@momo-the-monster @anatawa12