Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Warn if project folder is in VCC's application directory. #40

Closed
anatawa12 opened this issue Dec 9, 2022 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI
Milestone

Comments

@anatawa12
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Few hours ago, my friend updated VCC and he lost all him projects because he saved Projects in VCC's application directory.

Describe the solution you'd like
To avoid such situation in the future, I want VCC to warn if we were creating new project into or adding existing projects in VCC application directory.

Describe alternatives you've considered
N/A

Additional context
In his case, VCC is installed to D:\VRChat Creator Companion and project is in D:\VRChat Creator Companion\Projects.

He says .minecraft directory for Minecraft (in AppData and consists of both application file and user data) is frequently modified by users, so he thought VCC's application folder is also be one place for projects.

There may be more people who think application folder is place for projects than developers thought.

@orels1 orels1 added enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI labels Jan 11, 2023
@anatawa12
Copy link
Contributor Author

anatawa12 commented Mar 11, 2023

Recent VCC 2.0.x update breaks projects of at least four users because lack of this. This is important for users.

@Sayamame-beans
Copy link

Sayamame-beans commented Mar 11, 2023

And one person said, "It is not general knowledge that projects should not be placed in the application's folder."
Since we are using an "SDK", it is doubtful that this logic will apply to us as developers, but I think it is still desirable to prevent accidents that can be prevented.

@Faxmashine
Copy link
Contributor

Faxmashine commented Apr 13, 2023

The installer used to delete everything in the VCC's installation folder. This has been fixed, and it only deleted folders and DLLs it created itself. User-created folders and files should be safe.

We did not add a warning about adding user folders to the installation folder (yet).

https://vcc.docs.vrchat.com/news/release-2.1.0/#installer-change

@KhopeshActual KhopeshActual added this to the 2.1.1 milestone Apr 13, 2023
@orels1 orels1 self-assigned this Apr 21, 2023
@orels1
Copy link
Contributor

orels1 commented Apr 24, 2023

Some in-progress screens that should help avoid these issues:

Image

Image

@orels1
Copy link
Contributor

orels1 commented Apr 24, 2023

Project path validator will now also check against the VCC exe path

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vcc-web Items specific to the new Web Version vpm-cli Issues related to the CLI
Projects
None yet
Development

No branches or pull requests

5 participants