Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VCC installs VRCSDK 3.5.0 into Unity 2019 Project without warning if VRCSDK is updated by dependencies #404

Closed
anatawa12 opened this issue Dec 14, 2023 · 1 comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core

Comments

@anatawa12
Copy link
Contributor

Describe the bug

VCC installs VRCSDK 3.5.0 into Unity 2019 Project without warning if VRCSDK is updated by dependencies.

To Reproduce

  1. Create Unity 2019 project with VRCSDK 3.3.0 or earlier.
  2. Try to package depends on VRCSDK 3.4.0 or later.
    You can use The Package depends on SDK Worlds 3.4.0 in https://anatawa12.github.io/vpm-repo-for-vcc-bug-testing/ for testing.
  3. Now VCC will upgrades VRCSDK 3.5.0 instead of 3.4.0

Expected behavior

VCC upgrades VRCSDK to 3.4.0 for that project.

If the dependencies actually needs VRCSDK 3.5.0 / later, VCC should fail to install that package with Unity Version Mismatch Error.

Screenshots

Screenshot 2023-12-14 132046
Screenshot 2023-12-14 132348

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.2

OS

Windows 11

Additional context

VCC should consider unity field during package resolution as my vrc-get does.

@anatawa12 anatawa12 added the bug Something isn't working label Dec 14, 2023
@orels1 orels1 added the vpm-core Issues related to the vpm-core label Dec 14, 2023
@orels1
Copy link
Contributor

orels1 commented Feb 20, 2024

Available in VCC 2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core
Projects
None yet
Development

No branches or pull requests

2 participants