Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VPM Resolver will be added to projects without resolver during migration #407

Closed
anatawa12 opened this issue Dec 14, 2023 · 2 comments
Labels
bug Something isn't working vpm-core Issues related to the vpm-core

Comments

@anatawa12
Copy link
Contributor

Describe the bug

VPM Resolver will be added to projects without resolver during migration.

In my project, VPM Resolver is omitted and I'm using another resolver because VPM Resolver is a embedded package and vrc-get resolver is a git UPM package.
A friend also excludes VPM Resolver from their project (and uses another resolver) for some reasons.

To Reproduce

  1. create Unity 2019 project
  2. remove VPM Resolver
  3. Migrate the project to 2022
  4. Now VPM Resolver is added

Expected behavior

VPM resolver should not be added if VPM resolver is not on the package list

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.2

OS

Windows 11

Additional context

I think this is related to #406

@anatawa12 anatawa12 added the bug Something isn't working label Dec 14, 2023
@orels1
Copy link
Contributor

orels1 commented Dec 14, 2023

Not related to #406. Similar to the Legacy SDK migration - the 2022 migration is also always adding a resolver, as it is desired in most cases.

We can adjust it to check before adding in the future though.

@orels1 orels1 added the vpm-core Issues related to the vpm-core label Dec 14, 2023
@orels1
Copy link
Contributor

orels1 commented Feb 20, 2024

Available in VCC 2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core
Projects
None yet
Development

No branches or pull requests

2 participants