Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] If we add package using + button, unity version compatibility is not considered #414

Closed
Sayamame-beans opened this issue Dec 29, 2023 · 1 comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core

Comments

@Sayamame-beans
Copy link

Describe the bug

For example, when we add SDK with + button to Unity2019 project, VCC tries to import 3.5.0 (for Unity2022 latest), and migration dialog is showed up.
This also happens for community packages, so it confuses users.

VCC should check the unity version field and choose as new version as possible that is compatible with the project's unity version.

To Reproduce

For easily repro,

  1. Create Unity 2019 project with VCC
  2. Remove World/Avatar SDK Package
  3. Add World/Avatar SDK using + button

Expected behavior

Import SDK 3.4.2 (for Unity2019 latest)

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.3

OS

Windows 10

Additional context

No response

@Sayamame-beans Sayamame-beans added the bug Something isn't working label Dec 29, 2023
@orels1 orels1 added the vpm-core Issues related to the vpm-core label Jan 9, 2024
@orels1
Copy link
Contributor

orels1 commented Feb 20, 2024

Available in VCC 2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core
Projects
None yet
Development

No branches or pull requests

2 participants