Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Installing from custom VPM repository hangs with no error reporting #6

Closed
bdunderscore opened this issue Sep 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bdunderscore
Copy link

Describe the bug
When trying to install a package from a custom VPM repository, the VCC GUI hangs, with no error message or log output.

To Reproduce
Steps to reproduce the behavior:

  1. Run: vpm add repo https://bdunderscore.github.io/vpm-repo/vpm-prerelease.json?
  2. In the VPM GUI, try to add or update Modular Avatar to a project
  3. The VPM GUI will hang on the installing message.

Expected behavior
The package should install - or failing that, an error message of some sort should be displayed.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Version 21H2
  • VCC version: 1.0.0
@momo-the-monster momo-the-monster added this to the Release 1.0.1 milestone Sep 19, 2022
@momo-the-monster
Copy link
Contributor

Thanks for the reports - I've added a proper wrapper for that async task to catch the issue, it now looks like this:
image

I also fixed the underlying issue, which was trying to parse a range (3.1.x) as a Version in order to compare them. We instead now parse it as a range and check that the version satisfies the range.

@momo-the-monster momo-the-monster self-assigned this Sep 19, 2022
@momo-the-monster momo-the-monster added the bug Something isn't working label Sep 19, 2022
@momo-the-monster
Copy link
Contributor

Fixed in 1.0.1 by changing the way dependency versions are checked when building the dependency tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants