runtime に BlendShapeProxy.m_merger を再初期化する #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
requested changes
Jun 28, 2022
| @@ -44,9 +53,10 @@ private void Start() | |||
| /// <param name="value"></param> | |||
| public void ImmediatelySetValue(BlendShapeKey key, float value) | |||
| { | |||
| if (m_merger != null) | |||
| var merger = Merger; | |||
| if (merger != null) | |||
There was a problem hiding this comment.
挙動が変わってしまっている点が気になります。
Start() するより前の段階で ImmediatelySetValue() を呼び出すとその状態で初期化され SetValue が走ってしまう、ということになってしまっていると思います。
| { | ||
| m_merger = new BlendShapeMerger(BlendShapeAvatar.Clips, transform); | ||
| } | ||
| m_merger.RestoreMaterialInitialValues(BlendShapeAvatar.Clips); |
There was a problem hiding this comment.
これが Destroy されたあとにアクセスされることを考えると
正確にはここで bool isDisposed という変数に対して true を代入しておいて
Merger の getter では if (isDisposed) return null; というのを書いた方がよさそうです。
|
Clear をやめて Reinitialize に変えます |
ousttrue
commented
Jun 28, 2022
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
変化が少なくなるように、 Clear をやめて Restart に変更しました。
There was a problem hiding this comment.
Reinitialize() などの方が命名としてはしっくりくるが、どうだろう。
There was a problem hiding this comment.
と内容がほぼ同じ。ということは Start を呼ぶ関数にしよう 🤔
Santarh
previously approved these changes
Jun 29, 2022
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Reinitialize() などの方が命名としてはしっくりくるが、どうだろう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1710