Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use javac to make the compiled class as well as the header. #241

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@rpavlik
Copy link
Member

rpavlik commented Mar 2, 2020

Should fix the CI build. Ignore the LGTM check, their service decided to break.

Should fix the CI build.
@russell-taylor

This comment has been minimized.

Copy link
Contributor

russell-taylor commented Mar 3, 2020

You're the best!

@russell-taylor russell-taylor merged commit a95e1a6 into master Mar 3, 2020
5 of 6 checks passed
5 of 6 checks passed
LGTM analysis: C/C++ Analysis failed (could not build the merge commit)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@russell-taylor russell-taylor deleted the fix-java branch Mar 3, 2020
@rpavlik

This comment has been minimized.

Copy link
Member Author

rpavlik commented Mar 3, 2020

glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.