From 98774b8093571a540fe8c272cf7e09335c9ad0b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Komnus=E4=B8=B6Q?= <40655746+quchuyuan@users.noreply.github.com> Date: Mon, 20 Mar 2023 13:50:12 -0700 Subject: [PATCH] delete registry after creation (#2107) * delete registry after creation * always run deletion * init env * set working dir * add sdk_helper * add sub_id * edit for debugging * try debugging * try deletion inside the notebook * delete in the same step * print registry name for debugging * remove deletion for testing. * change everything back for final pr * modify format * make deletion inside the ipnb * try sdk deletion * try sdk * use verified api. * change format * Update registry-create.ipynb --- infra/sdk_helpers.sh | 1 + .../resources/registry/registry-create.ipynb | 29 ++++++++++++++++--- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/infra/sdk_helpers.sh b/infra/sdk_helpers.sh index 310c46fe61..cfc3e6873a 100644 --- a/infra/sdk_helpers.sh +++ b/infra/sdk_helpers.sh @@ -813,6 +813,7 @@ function replace_template_values() { -e "s//$(echo "$REGISTRY_NAME")/g" \ -e "s//$(echo "$ARC_CLUSTER_NAME")/g" \ -e "s//$(echo "$ARC_COMPUTE_NAME")/g" \ + -e "s//$(echo "$timestamp")/g" \ -e "s/DefaultAzureCredential/AzureCliCredential/g" \ -e "s/InteractiveBrowserCredential/AzureCliCredential/g" \ -e "s/@pipeline(/&force_rerun=True,/g" \ diff --git a/sdk/python/resources/registry/registry-create.ipynb b/sdk/python/resources/registry/registry-create.ipynb index ee440457a3..55ec08cc07 100644 --- a/sdk/python/resources/registry/registry-create.ipynb +++ b/sdk/python/resources/registry/registry-create.ipynb @@ -90,7 +90,10 @@ " credential=credential,\n", " subscription_id=\"\",\n", " resource_group_name=\"\",\n", - ")" + ")\n", + "\n", + "subscription_id = (\"\",)\n", + "resource_group_name = \"\"" ] }, { @@ -145,7 +148,9 @@ "print(registry)\n", "\n", "# You can override the registry name if needed\n", - "registry.name = \"DemoRegistryPython\"\n", + "ts = \"\"\n", + "registry.name = \"DemoRegistryPython\" + \"-\" + ts\n", + "print(f\"the registry name: {registry.name}\")\n", "\n", "registry = ml_client.registries.begin_create(registry=registry).result(\n", " timeout=LROConfigurations.POLLING_TIMEOUT\n", @@ -180,11 +185,12 @@ ] }, { + "attachments": {}, "cell_type": "markdown", "id": "5468f90b", "metadata": {}, "source": [ - "### 2.1 List Registries\n", + "### 2.2 List Registries\n", "\n", "This will list all registries that exist under the resource group of your `MLClient`. " ] @@ -200,13 +206,28 @@ " print(reg.name)" ] }, + { + "attachments": {}, + "cell_type": "markdown", + "id": "011f0562", + "metadata": {}, + "source": [ + "### 2.3 Delete Registry\n", + "\n", + "This will delete the previously created registry." + ] + }, { "cell_type": "code", "execution_count": null, "id": "5f2c0f69", "metadata": {}, "outputs": [], - "source": [] + "source": [ + "ml_client.registries.begin_delete(name=registry.name).result(\n", + " timeout=LROConfigurations.POLLING_TIMEOUT\n", + ")" + ] } ], "metadata": {