Add Clojure 1.6 Runtime #121

Open
speige opened this Issue Dec 14, 2013 · 16 comments

Projects

None yet

2 participants

@speige
Contributor
speige commented Dec 14, 2013

No description provided.

Contributor

Perhaps in the process the zip files for both Clojure and Clojure script could just be named:

Clojure.zip
ClojureScript.zip

But this may require some code changes to support.

Contributor
speige commented Dec 14, 2013

Do you think there's any value in keeping both versions 1.5 & 1.6 available in vsclojure? I assume most people will want the latest version. If so, I don't mind if the few who want an older one have to do a custom setup.

Contributor

I'd say if there is not a lot of work involved in making it support
multiple versions then yes. I would agree most people will want the latest
version.

On Sat, Dec 14, 2013 at 3:33 PM, Devin Garner notifications@github.comwrote:

Do you think there's any value in keeping both versions 1.5 & 1.6
available in vsclojure? I assume most people will want the latest version.
If so, I don't mind if the few who want an older one have to do a custom
setup.


Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/121#issuecomment-30588019
.

Contributor

Reference patch in #116

Contributor

@speige what is your strategy for applying this patch? I'm going to apply it by hand because I don't of any other way. Hopefully it applies cleanly to the 1.6 branch.

Contributor

Okay I was able to hand patch 1.6. It compiles fine. I wish I could attach a zip file to this issue!!!!! I'll make a zip of the binaries and add them to the project. The name will be ClojureCLR-1.6.0.zip. This is a release .NET 4.0 build (non ILMerged).

Contributor

If I've screwed something up feel free to grab my fork of ClojureCLR. I've pushed the patch there as a reference and to assist us in building the latest code.

https://github.com/frankhale/clojure-clr

Contributor

FYI, while I've added the 1.6 runtime to the repo, I have not specifically done anything with it so it will not be unzipped when installing vsClojure.

Contributor

@speige, since I did this work a while ago I'll probably need to sync against the latest ClojureCLR version. Did we want to start supporting both stable and unstable versions of ClojureCLR?

Contributor
speige commented Feb 3, 2014

I think we should support the latest stable and the most recent unstable. I doubt anyone would want to go back to an older-stable release.

Long term, if we had thousands of users, we might consider supporting several older-stable releases, but right now I think it's extra work that provides little benefit.

If there are updates to ClojureCLR 1.6, we should probably get a new zip added to vsClojure. However, we could wait on this & ClojureScript runtime upgrades until we have enough improvements to warrant uploading a new vsClojure version to the gallery. If ClojureScript/ClojureCLR releases every week & we release every month, we'll end up re-zipping the runtimes 3 more times than we need to.

Hopefully as we get more contributors we can release more often.

Contributor

Since I'm also updating Clojurescript I will pull the latest ClojureCLR and add the patch they you gave me and put that into the runtimes folder.

Contributor

This pertains to using git to merge the patch file against the latest ClojureCLR code. Using git to merge it failed. I'm going to hand merge and try to get a current patch.

"C:\Program Files (x86)\Git\bin\git.exe" am --3way --signoff "C:/Users/Frank/Desktop/0001-PATCH-Add-NDesk.Options-ManyConsole-via-NuGet-to-all.patch"
Applying: Add NDesk.Options/ManyConsole via NuGet to allow easier command-line options. Allow compiling multiple clj into a single .dll: (Add -i & -u command-line switches, Modify GenClass to use existing CompilerContext, & Modify RT to accept list of clj files)
Using index info to reconstruct a base tree...
M   Clojure/Clojure.Compile/Clojure.Compile.csproj
M   Clojure/Clojure.Compile/Compile.cs
M   Clojure/Clojure/Lib/RT.cs
M   Clojure/build.proj
<stdin>:65: trailing whitespace.
  <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
<stdin>:295: trailing whitespace.
          bool hasMain = outputAssemblyName.ToLower().Trim().EndsWith(".exe");         
<stdin>:395: trailing whitespace.
    <Exec Command="$(cljc) -i clojure.test-clojure.genclass.examples -i clojure.test-clojure.protocols.examples -i clojure.test-clojure.attributes" 
<stdin>:399: trailing whitespace.
    <Exec Command="mono $(cljc) -i clojure.test-clojure.genclass.examples -i clojure.test-clojure.protocols.examples -i clojure.test-clojure.attributes" 
error: patch failed: Clojure/Clojure.Compile/Clojure.Compile.csproj:30
error: Clojure/Clojure.Compile/Clojure.Compile.csproj: patch does not apply
error: patch failed: Clojure/Clojure.Compile/Compile.cs:1
error: Clojure/Clojure.Compile/Compile.cs: patch does not apply
error: patch failed: Clojure/Clojure/CljCompiler/GenClass.cs:83
error: Clojure/Clojure/CljCompiler/GenClass.cs: patch does not apply
error: patch failed: Clojure/Clojure/Lib/RT.cs:24
error: Clojure/Clojure/Lib/RT.cs: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.
Patch failed at 0001 Add NDesk.Options/ManyConsole via NuGet to allow easier command-line options. Allow compiling multiple clj into a single .dll: (Add -i & -u command-line switches, Modify GenClass to use existing CompilerContext, & Modify RT to accept list of clj files)
The copy of the patch that failed is found in:
   c:/Users/Frank/Documents/GitHub/clojure-clr/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Done
Contributor

Clojure 1.6 (on JVM) has been released but ClojureCLR still lags behind and there is no official 1.6 yet. As soon as that happens and I make the patch to the compiler I will close this. Hopefully that will happen soon.

Contributor

There is still no Clojure 1.6 CLR release yet. I have no idea when this will get released.

Contributor

Still no 1.6 official release as far as I can tell

@frankhale frankhale removed this from the Version 2.2 milestone Aug 22, 2014
Contributor

Yay ClojureCLR 1.6 has finally been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment