From d8d32f535dce9b78ba2dff6dd1e29e5973f46767 Mon Sep 17 00:00:00 2001 From: bendera Date: Fri, 29 Nov 2024 19:52:24 +0100 Subject: [PATCH 1/4] Make divider color visible in all themes --- dev/vscode-divider/basic-example.html | 31 +++++++++++++++++++++ src/vscode-divider/vscode-divider.styles.ts | 3 +- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 dev/vscode-divider/basic-example.html diff --git a/dev/vscode-divider/basic-example.html b/dev/vscode-divider/basic-example.html new file mode 100644 index 000000000..9dec0fa03 --- /dev/null +++ b/dev/vscode-divider/basic-example.html @@ -0,0 +1,31 @@ + + + + + + + VSCode Elements + + + + + + + +

Divider

+
+ +

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque quis ligula id magna vulputate mollis vel eu massa. Nam cursus velit in egestas viverra. Pellentesque euismod porta elit, sed imperdiet lectus ultrices vel. Aenean eleifend interdum tincidunt. Fusce interdum leo vitae ante egestas imperdiet nec vel quam. Integer dictum eget tortor id porta. Ut faucibus, lacus a interdum molestie, neque urna luctus purus, quis vulputate est est sit amet lectus. Sed eros mauris, lacinia sed lacinia in, fringilla in neque. Nulla eu auctor tortor.

+ +

Maecenas non velit velit. Fusce tempor risus a gravida volutpat. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Etiam tincidunt condimentum orci, sit amet consequat odio semper non. Ut a pharetra orci. Ut et aliquet quam. Phasellus a ullamcorper metus. Sed eu ornare magna. In ac semper sem. Cras eget fringilla velit. Praesent convallis ex ac massa semper efficitur. Aliquam ac magna ut arcu ultrices ullamcorper a sit amet eros. Nunc congue massa sit amet leo lacinia cursus. Aenean porta non ligula et euismod.

+ +
+ + + diff --git a/src/vscode-divider/vscode-divider.styles.ts b/src/vscode-divider/vscode-divider.styles.ts index 38d00c2c8..fd84d9494 100644 --- a/src/vscode-divider/vscode-divider.styles.ts +++ b/src/vscode-divider/vscode-divider.styles.ts @@ -5,11 +5,12 @@ const styles: CSSResultGroup = [ defaultStyles, css` :host { - background-color: var(--vscode-widget-border); + background-color: var(--vscode-foreground); display: block; height: 1px; margin-bottom: 10px; margin-top: 10px; + opacity: 0.4; } `, ]; From 563ed9110b57a68e3e7b30c2dd72d66d8bd38690 Mon Sep 17 00:00:00 2001 From: bendera Date: Fri, 29 Nov 2024 19:54:59 +0100 Subject: [PATCH 2/4] Update changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e6055ddc..f0c35934c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [Unreleased] + +### Fixed + +- **Divider**: Make component color visible in all themes. + ## [1.9.0] - 2024-11-26 ## Added From 93875285a26ab67bbfe33500b5aeed3a1f2998d5 Mon Sep 17 00:00:00 2001 From: bendera Date: Fri, 29 Nov 2024 19:55:22 +0100 Subject: [PATCH 3/4] Fix header levels in changelog --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f0c35934c..f8a46deab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,12 +12,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [1.9.0] - 2024-11-26 -## Added +### Added - Add support for two-way binding with form controls in Vue. - **ContextMenu**: Added `preventClose` property. -## Fixed +### Fixed - **ContextMenu**: `show` attribute was not synchronized correctly. From 8d29fea44d0b66a89e300e08b52ec0abbe9d3031 Mon Sep 17 00:00:00 2001 From: bendera Date: Fri, 29 Nov 2024 19:59:10 +0100 Subject: [PATCH 4/4] Upgrade Playground --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index cef85f777..832f03e6d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,7 +26,7 @@ "@types/node": "^22.9.0", "@typescript-eslint/eslint-plugin": "^8.13.0", "@typescript-eslint/parser": "^8.13.0", - "@vscode-elements/webview-playground": "^1.2.2", + "@vscode-elements/webview-playground": "^1.3.0", "@vscode/codicons": "^0.0.36", "@web/dev-server": "^0.4.6", "@web/dev-server-esbuild": "^1.0.3", @@ -4054,9 +4054,9 @@ } }, "node_modules/@vscode-elements/webview-playground": { - "version": "1.2.2", - "resolved": "https://registry.npmjs.org/@vscode-elements/webview-playground/-/webview-playground-1.2.2.tgz", - "integrity": "sha512-8S7eTr/RjfRcCKztl1guZKUycQ59/POBukugfE2abLNZROJTxaDbCZXKMTvrbjrm3klv1jxC77sFedDhS1IBHQ==", + "version": "1.3.0", + "resolved": "https://registry.npmjs.org/@vscode-elements/webview-playground/-/webview-playground-1.3.0.tgz", + "integrity": "sha512-IOGaTjiRcKcdyBsxR/ubPd21J9c2KFTFJKrfJA4IS4fSV+LvVIbW30UhAnysy8njnVbtoLECh7gxmcU+xFfoow==", "dev": true, "license": "MIT" }, @@ -14826,9 +14826,9 @@ } }, "@vscode-elements/webview-playground": { - "version": "1.2.2", - "resolved": "https://registry.npmjs.org/@vscode-elements/webview-playground/-/webview-playground-1.2.2.tgz", - "integrity": "sha512-8S7eTr/RjfRcCKztl1guZKUycQ59/POBukugfE2abLNZROJTxaDbCZXKMTvrbjrm3klv1jxC77sFedDhS1IBHQ==", + "version": "1.3.0", + "resolved": "https://registry.npmjs.org/@vscode-elements/webview-playground/-/webview-playground-1.3.0.tgz", + "integrity": "sha512-IOGaTjiRcKcdyBsxR/ubPd21J9c2KFTFJKrfJA4IS4fSV+LvVIbW30UhAnysy8njnVbtoLECh7gxmcU+xFfoow==", "dev": true }, "@vscode/codicons": { diff --git a/package.json b/package.json index 5698c0873..398eda445 100644 --- a/package.json +++ b/package.json @@ -154,7 +154,7 @@ "@types/node": "^22.9.0", "@typescript-eslint/eslint-plugin": "^8.13.0", "@typescript-eslint/parser": "^8.13.0", - "@vscode-elements/webview-playground": "^1.2.2", + "@vscode-elements/webview-playground": "^1.3.0", "@vscode/codicons": "^0.0.36", "@web/dev-server": "^0.4.6", "@web/dev-server-esbuild": "^1.0.3",