Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roughly half the icons are not loading #2673

Closed
ghost opened this issue Dec 31, 2020 · 6 comments · Fixed by #2677 or #2678
Closed

Roughly half the icons are not loading #2673

ghost opened this issue Dec 31, 2020 · 6 comments · Fixed by #2677 or #2678
Assignees

Comments

@ghost
Copy link

ghost commented Dec 31, 2020

This addon doesn't seem to be loading icons for a random half of the supported file types. I don't know what I can do to figure out what's wrong, but I did confirm that jinja, cfm, and gulp should be supported by this extension.
icons_not_working

@robertohuertasm
Copy link
Member

Some of the icons are just enabled when a extension is installed that supports a specific language ID. Try installing a jinja extension.

@ghost
Copy link
Author

ghost commented Jan 1, 2021

I have "Better Jinja" installed which correctly formats my jinja files with .jinja extensions, but has no effect on the icon.

@robertohuertasm
Copy link
Member

I see... Better Jinja uses lots of different language ids. For the moment we only support jinja language id. The quick fix is just to set a file association in your vscode settings:

 "files.associations": {
    "*.jinja": "jinja"
  }

I'll provide a fix for this.

@robertohuertasm
Copy link
Member

@pcsagan for the rest of files, you need a extension declaring a language id for them to be enabled. The way vscode sets the icon is file name > file extension > language id. This means that if we declared file extensions authors creating language extensions wouldn't be able to define which extensions are the right ones. Or better put, they wouldn't be able to overwrite our defaults. That's why we decided to completely rely in language extensions.

In the end, someone working with some specific files will install a language extension and in the case he won't, the user can always configure file-icon associations.

Btw, there's a new PR adding more language ids for jinja.

@robertohuertasm
Copy link
Member

For cml it seems that they decided to change again the language id (see #1079). I'll provide another PR.

robertohuertasm added a commit that referenced this issue Jan 2, 2021
It seems CFM extensions are using a new language id. I've kept the old one in case some extension is
still using it although I have reviewed all the cfm extensions and they don't seem to be supporting
anymore.

fixes #2673
@robertohuertasm robertohuertasm self-assigned this Jan 2, 2021
@robertohuertasm
Copy link
Member

Forgot to mention that the .gulp extension is not supported. See what we're currently supporting for Gulp.

robertohuertasm added a commit that referenced this issue Jan 5, 2021
It seems CFM extensions are using a new language id. I've kept the old one in case some extension is
still using it although I have reviewed all the cfm extensions and they don't seem to be supporting
anymore.

fixes #2673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant