Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony lock filename. #1477

Merged
merged 3 commits into from Mar 8, 2018

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Feb 18, 2018

Fixes #1460

Changes proposed:

  • Add

@JimiC JimiC added this to the Next milestone Feb 18, 2018
@JimiC JimiC requested a review from a team February 18, 2018 16:18
@codecov
Copy link

codecov bot commented Feb 18, 2018

Codecov Report

Merging #1477 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1477   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2620    2620           
  Branches      134     134           
======================================
  Hits         2620    2620
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61840e7...b7ffab6. Read the comment docs.

jens1o
jens1o previously approved these changes Feb 20, 2018
@robertohuertasm
Copy link
Member

@JimiC could you have a look at this conflict so we can merge it?

@JimiC
Copy link
Member Author

JimiC commented Feb 26, 2018

Already on it.

@JimiC JimiC dismissed stale reviews from robertohuertasm and jens1o via 1e78361 February 26, 2018 22:04
@JimiC JimiC requested a review from a team February 26, 2018 22:07
@robertohuertasm robertohuertasm merged commit 6345b78 into vscode-icons:master Mar 8, 2018
@JimiC JimiC deleted the support_symfony branch March 8, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants