Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Maven #1522

Merged
merged 2 commits into from Mar 18, 2018
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Mar 18, 2018

Fixes #1508

Changes proposed:

  • Add

@JimiC JimiC added this to the Next milestone Mar 18, 2018
@JimiC JimiC requested a review from a team March 18, 2018 11:18
@JimiC JimiC changed the title Support maven Add support for Maven Mar 18, 2018
@codecov
Copy link

codecov bot commented Mar 18, 2018

Codecov Report

Merging #1522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1522   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2626    2621    -5     
  Branches      133     133           
======================================
- Hits         2626    2621    -5
Impacted Files Coverage Δ
src/icon-manifest/supportedFolders.ts 100% <ø> (ø) ⬆️
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️
test/iconGenerator/functionality.test.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d69923...09746da. Read the comment docs.

extensionsGlob: ['json', 'js', 'ts', 'coffee'],
filename: true,
format: FileFormat.svg,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Does this branch bases on the wallaby branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I thought I corrected that. Sorry. Good catch.

@robertohuertasm robertohuertasm merged commit 888c0cb into vscode-icons:master Mar 18, 2018
@JimiC JimiC deleted the support_maven branch March 18, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants