Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate extension-based support for ActionScript files #1765

Merged
merged 3 commits into from Nov 17, 2018
Merged

Add alternate extension-based support for ActionScript files #1765

merged 3 commits into from Nov 17, 2018

Conversation

admvx
Copy link
Contributor

@admvx admvx commented Nov 1, 2018

There was language-based support for ActionScript files already, via the nextgenas extension, but this adds a second version (disabled by default) for .as files, which aligns more with Adobe's branding.

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #1765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1765   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          52      52           
  Lines        3003    3003           
  Branches      156     156           
======================================
  Hits         3003    3003
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9968e14...4cd61a3. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Nov 1, 2018

You should add the languageid and remove the file extension. This way someone can still benefit from the syntax highlighting and the alternative icon.

@admvx
Copy link
Contributor Author

admvx commented Nov 1, 2018

Ah, sorry for missing that! I switched out the languageid as I personally don't use any specific VSCode extension with ActionScript, but I can remedy that separately.

@JimiC JimiC added this to the Next milestone Nov 12, 2018
@robertohuertasm robertohuertasm merged commit 4e0e2ef into vscode-icons:master Nov 17, 2018
@admvx admvx deleted the actionscript-v2 branch October 8, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants