New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new supported folders aliases #1770

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mgcrea

mgcrea commented Nov 6, 2018

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Adds several useful folder icon aliases.

@codecov

This comment has been minimized.

codecov bot commented Nov 6, 2018

Codecov Report

Merging #1770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1770   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          52      52           
  Lines        3003    3003           
  Branches      156     156           
======================================
  Hits         3003    3003
Impacted Files Coverage Δ
src/icon-manifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0e2ef...1a626dc. Read the comment docs.

@JimiC JimiC requested a review from vscode-icons/development Nov 6, 2018

@JimiC

This comment has been minimized.

Member

JimiC commented Nov 6, 2018

I'm gonna leave the approval of this PR to @robertohuertasm.

@jens1o

jens1o approved these changes Nov 6, 2018

@jens1o

jens1o approved these changes Nov 6, 2018

I like these changes. Eager to get @robertohuertasm 's final decision.

@JimiC JimiC added the folder icons label Nov 12, 2018

@JimiC JimiC added this to the Next milestone Nov 12, 2018

@@ -11,7 +11,7 @@ export const extensions: IFolderCollection = {
{ icon: 'app', extensions: ['app', '.app'], format: FileFormat.svg },
{
icon: 'asset',
extensions: ['assets', '.assets'],
extensions: ['assets', '.assets', 'files'],

This comment has been minimized.

@robertohuertasm

robertohuertasm Nov 17, 2018

Member

I'm not sure of how files alias relates to assets. What's the rationale? I see this more of a subfolder of assets.

This comment has been minimized.

@mgcrea

mgcrea Nov 18, 2018

On some projects I used to use files in place of assets, but I agree it can/should be a subfolder of a more generic assets folder.

This comment has been minimized.

@robertohuertasm

robertohuertasm Nov 18, 2018

Member

I mean, don't get me wrong, it can be whatever you want, but for that we have customization support. We only tend to implement generalized usages.

Show resolved Hide resolved src/icon-manifest/supportedFolders.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment