New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command to underline current line. #66

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@adimascio
Copy link

adimascio commented Oct 22, 2017

It tries to work as emacs does, by checking if current line is already
underlined or not. If it's not, then insert a new line of '=', otherwise
cycle over underline characters.

Map the command to 'Ctrl+=' and add tests for it.

Add new command to underline current line.
It tries to work as emacs does, by checking if current line is already
underlined or not. If it's not, then insert a new line of '=', otherwise
cycle over underline characters.

Map the command to 'Ctrl+=' and add tests for it.
@lextm

This comment has been minimized.

Copy link
Member

lextm commented Oct 22, 2017

Thanks for sharing, but my concern is that this feature alone has little to do with reStructuredText. It is so generic that you can use it easily for other languages.

Then you should make a new extension out of it, instead of keeping it in a pull request for this extension. That can maximize the value of your code. :)

@adimascio

This comment has been minimized.

Copy link
Author

adimascio commented Oct 23, 2017

Hi,

Thanks for your quick feedback. I understand your concern however reStructuredText is the only language where I find myself having such a need. This feature is implemented in the emacs' reStructuredText mode and I've missed it quite a lot since I've moved to vscode as my main code editor, hence my pull request.

Anyhow, if you don't feel like integrating it, no problem.

@lextm

This comment has been minimized.

Copy link
Member

lextm commented Oct 24, 2017

Thanks for the extra information. That helps me understand why it might be helpful.

I will review the code and let you know what might be updated.

@lextm lextm merged commit 20c3bd7 into vscode-restructuredtext:master Dec 11, 2017

@lextm lextm removed the in progress label Dec 11, 2017

@lextm

This comment has been minimized.

Copy link
Member

lextm commented Dec 11, 2017

The code review is finally finished and the changes are merged. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment