New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed `null` value in stack frame to `undefined` #32

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@woubuc
Copy link
Contributor

woubuc commented Jan 3, 2019

The VS Code debugging API requires the path property in a stack frame source object to be either a string or undefined. The current value null isn't supported and can cause (as it did for me) issues where no debug information is displayed at all.

See documentation here and here.

This PR changes the null value to undefined to fix this error.

Changed `null` value in stack frame to `undefined`
To comply with VS Code debugging API and to fix sporadic bugs
@Gama11

This comment has been minimized.

Copy link
Member

Gama11 commented Jan 3, 2019

There's no undefined in Haxe (see Travis compilation errors), you would need to use js.Lib.undefined.

@woubuc

This comment has been minimized.

Copy link
Contributor

woubuc commented Jan 3, 2019

Fixed, should compile correctly now.

@Gama11 Gama11 merged commit 9ee970d into vshaxe:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment