no-pattern-restrictions rule #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Scenario, ScenarioOutline and Background patterns apply to corresponding names and descriptions - Make all patterns case insensitive - Make sure rule doesn't break on an empty scenario - Add violated pattern to error message for more clarity (multiple patterns can produce multiple errors)
vsiakka
commented
May 4, 2019
| it('doesn\'t raise errors when there are no violations', function() { | ||
| runTest('no-restricted-patterns/NoViolations.feature', { | ||
| 'Global': [ | ||
| '^.*disallowed.*$' | ||
| ]}, []); | ||
| }); | ||
|
|
||
| it('detects errors for features, scenarios, backgrounds, and scenario outlines', function() { | ||
| runTest('no-restricted-patterns/Violations.feature', { | ||
| it('detects errors in Feature names and descriptions that match the Feature or Global config', function() { |
There was a problem hiding this comment.
I split up the tests, because the number of errors was becoming pretty big and the file was becoming unreadable.
Pull Request Test Coverage Report for Build 430
💛 - Coveralls |
…'t really share much code
vsiakka
force-pushed
the
noRestrictedPatterns
branch
from
5baf630
to
e4afbc1
Compare
vsiakka
commented
May 4, 2019
| function checkNameAndDescription(node, restrictedPatterns, errors) { | ||
| restrictedPatterns[node.type] | ||
| .forEach(function(pattern) { | ||
| check(node, 'name', pattern, errors); |
There was a problem hiding this comment.
Scenarios and ScenarioOutlines also have a name
Scenarios and ScenarioOutlines and Background also have a description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding names and descriptions (consistency with Feature)
patterns can produce multiple errors)
@jhedstrom fyi, i realized these bugs after merging the PR and thinking more about the rule. My turn around time on PRs has been poor so i decided to fix them myself since I had some time today.