Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Indents are single spaces since latest update #28

Closed
Dreamsync opened this issue Mar 28, 2021 · 20 comments
Closed

[BUG] Indents are single spaces since latest update #28

Dreamsync opened this issue Mar 28, 2021 · 20 comments
Labels
Projects
Milestone

Comments

@Dreamsync
Copy link

@Dreamsync Dreamsync commented Mar 28, 2021

Describe the bug
Since latest update with new auto undent with multiple enter presses, the tab feature is now not working as expected - it is doing single spaces rather than full tabs. I can undent with shift+tab, but tab alone only indents a single space.

Desktop (please complete the following information):

  • OS: OSX
  • Obsidian Version: 0.11.9
@Dreamsync Dreamsync added the bug label Mar 28, 2021
@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 28, 2021

I can confirm that it persist in plugin version 1.0.14
(@vslinko you may update the template to ask users about plugin version, and again thanks for your hard work )

@ShreyasKallingal
Copy link

@ShreyasKallingal ShreyasKallingal commented Mar 29, 2021

Do you have steps to reproduce this behavior? It's working fine for me.

@Dreamsync
Copy link
Author

@Dreamsync Dreamsync commented Mar 29, 2021

I saw in Discord that someone had an unrelated issue with this plugin and restarting Obsidian fixed it.

I just now closed and reopened Obsidian and it solved the issue for me.

So, there is something funny going on, but i think we can consider this closed with the caveat that it should be made clear that restarting Obsidian is sometimes required to clear little bugs like this.

@Dreamsync Dreamsync closed this Mar 29, 2021
@Dreamsync
Copy link
Author

@Dreamsync Dreamsync commented Mar 29, 2021

I spoke too soon - looks like the issue is happening again.

https://www.loom.com/share/661706943ab54963b8865ca4f6566fd9

@Dreamsync Dreamsync reopened this Mar 29, 2021
@ShreyasKallingal
Copy link

@ShreyasKallingal ShreyasKallingal commented Mar 29, 2021

Ah, yeah this happened to me. Probably best to keep this open until it's addressed.

@vslinko
Copy link
Owner

@vslinko vslinko commented Mar 29, 2021

@Dreamsync Can't reproduce the issue. Could you please check your tabulation settings?

Screenshot 2021-03-29 at 16 04 27

@vslinko vslinko added the hold label Mar 29, 2021
@Quorafind
Copy link

@Quorafind Quorafind commented Mar 29, 2021

@vslinko I can repro it if I closed the option to use spaces rather than tabs, which is normal before 1.0.14. But things went normal if I open the option.

@vslinko
Copy link
Owner

@vslinko vslinko commented Mar 29, 2021

@Quorafind Looks like it's expected behaviour since I added indentation detector.
When your choice in Obsidian settings to use tabs, plugin adds tabs, otherwise it adds spaces.

Please close the issue If you agree.

@Quorafind
Copy link

@Quorafind Quorafind commented Mar 29, 2021

@vslinko yes, but I didn't find an option to close issue.. Sorry

@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 29, 2021

@Dreamsync should be tagged instead of you @Quorafind,
The intending behaviour on 1.0.15 works also for me as another affected user I think the issue can be closed

@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 29, 2021

in 1.0.16 bug when Tab sometimes create only one space instead of four spaces indent persist

@Dreamsync
Copy link
Author

@Dreamsync Dreamsync commented Mar 29, 2021

The issue persists.

I just now updated the outliner plugin to the most recent update, and double checked that the tab indentation setting is turned on in the Editor settings.

With outliner plugin activated, tabs are only creating single spaces.. if i turn off outliner plugin, tabs work properly.

@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 29, 2021

With tab turned off only one space to indent is possible to produce in outline mode.
This is produced when I try to outline

- A
 - B
  - C
   - C
   - D
   - E
    - F

image

@vslinko vslinko removed the hold label Mar 29, 2021
@vslinko vslinko added this to the 1.1.0 milestone Mar 29, 2021
@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 29, 2021

In 1.0.18 after update the behavior persisted, but turning on and off "Use Tab" in Obsidian Editor helped and Tab started working as expected, I will observe further

What I also observed that sometimes tab outlining on the existing row doesn't work and turning on and off "Use Tab" helps
(When I have coursor in the row with C, I cannot indent apart the very moment I created the bullet, it persist until I turn off and again on "Use Tab") It may be an Obsidian bug

- A
    -   B
    -  C

@iiz00
Copy link

@iiz00 iiz00 commented Mar 29, 2021

In 1.0.18, even if 'Use Tabs' is on, indent seems to consist of spaces, not tab.

@vslinko
Copy link
Owner

@vslinko vslinko commented Mar 31, 2021

Fixed one broken case in https://github.com/vslinko/obsidian-outliner/releases/tag/1.0.19 and also added debug logs.

Please check that problem is solved for you.

If it's not, please send video or gif with debug logs enabled:

  • Enable debug mode in the plugin settings tab
  • Open DevTools by pressing Cmd+Option+I or Control+Shift+I
  • Reproduce an issue while screen is recorded

@vslinko
Copy link
Owner

@vslinko vslinko commented Apr 1, 2021

Closing the issue. If problem still exists please reopen the issue or create a new one.

@vslinko vslinko closed this Apr 1, 2021
@santiyounger
Copy link

@santiyounger santiyounger commented Apr 2, 2021

This plugin is amazing! however I've had the exact same issue.

The issue comes and goes almost randomly. I was about to record a video and all of the sudden the error disappeared. but it's the exact same thing where it creates spaces instead of indents.

I set things up in setting > editor as shown in screenshot above

It's after some times when I refresh Obsidian that the error goes away, but it comes back randomly.

If it returns I can record my screen with inspector to show

I'm on version 1.0.23
Linux Garuda
Obsidian 0.11.12

@vslinko vslinko reopened this Apr 3, 2021
@vslinko vslinko added this to Ordered backlog in Board Apr 3, 2021
@vslinko
Copy link
Owner

@vslinko vslinko commented Apr 3, 2021

Found another invalid case.

If Obsidian "Use tab" setting never changed, Obsidian says to plugin it's undefined and in this case plugin assumes that it's 1 whitespace.

@vslinko
Copy link
Owner

@vslinko vslinko commented Apr 3, 2021

Should be fixed in https://github.com/vslinko/obsidian-outliner/releases/tag/1.0.25

Please check and report

@vslinko vslinko moved this from Ordered backlog to Waiting for feedback in Board Apr 3, 2021
@vslinko vslinko closed this Apr 5, 2021
@vslinko vslinko moved this from Waiting for feedback to Done in Board Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Board
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants