New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodingHashBean should support encoding salts #20

Closed
dfish3r opened this Issue Apr 7, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@dfish3r
Member

dfish3r commented Apr 7, 2015

The EncodingHashBean has a weird sort of asymmetry.
The #compare method will properly compare a salted hash, if the salt appended.
However the #hash method does not properly append a salt to hash.
It cannot know whether the input array contains a salt.

Add a salted property to the EncodingHashBean which will allow the code to use the last parameter provided to #hash as the salt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment