Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComments
added a commit
that referenced
this issue
Apr 7, 2015
serac
closed this
in
#21
Apr 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dfish3r commentedApr 7, 2015
The EncodingHashBean has a weird sort of asymmetry.
The #compare method will properly compare a salted hash, if the salt appended.
However the #hash method does not properly append a salt to hash.
It cannot know whether the input array contains a salt.
Add a salted property to the EncodingHashBean which will allow the code to use the last parameter provided to #hash as the salt.