New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make password attribute configurable #111

Closed
rkorn86 opened this Issue Jul 18, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rkorn86
Copy link
Contributor

rkorn86 commented Jul 18, 2016

Instead of hardcoding the userPassword attribute in https://github.com/vt-middleware/ldaptive/blob/master/core/src/main/java/org/ldaptive/auth/AbstractCompareAuthenticationHandler.java#L67 it would be better to make it configurable. Our company uses different passwords for different services and allow password reading via ACL for different manager binds. So this is a real scenario.

@rkorn86

This comment has been minimized.

Copy link
Contributor

rkorn86 commented Jul 18, 2016

@dfish3r: @mmoayyed suggested me to write to you, because i implemented a solution for this issue inside Apereo CAS. Having the fix upstream is much better, but I dont understand the ldaptive code very well. I did not find the exact point how to extend your XSL Schema. The following pull request will show, how far I got. Hopefully helpfull.

@rkorn86

This comment has been minimized.

Copy link
Contributor

rkorn86 commented Jul 21, 2016

@dfish3r do you have any plan, when 1.2 will be finally released or can say, which fixes are missing for a 1.2 release?

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Jul 22, 2016

I'm hopeful I can get it done next week.

@dfish3r dfish3r closed this Jul 22, 2016

dfish3r added a commit that referenced this issue Jul 28, 2016

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment