New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equals delegating to hashCode #117

Closed
dfish3r opened this Issue Oct 28, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@dfish3r
Copy link
Member

dfish3r commented Oct 28, 2016

There are several classes where the equals implementation delegates to hashCode.
This is incorrect and can lead to collisions when objects are placed in Collections.

dfish3r added a commit that referenced this issue Oct 28, 2016

equals should not delegate to hashCode.
Refactor broken equals to use property comparison.
See #117

dfish3r added a commit that referenced this issue Nov 1, 2016

@dfish3r dfish3r closed this Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment