New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pool log levels #19

Closed
dfish3r opened this Issue Dec 22, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@dfish3r
Copy link
Member

dfish3r commented Dec 22, 2014

The connection pool emits errors for each connection that fails on #initialize.
Given the nature of pools, it may be incorrect to consider that an error.

Review current log levels and adjust accordingly.

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Aug 3, 2015

Any periodic tasks should emit logs at trace level.

@serac

This comment has been minimized.

Copy link
Member

serac commented Aug 17, 2015

Perhaps a logging engine message diagnostic context can help inform loggers about the calling context, e.g. background or foreground thread.

@serac

This comment has been minimized.

Copy link
Member

serac commented Aug 17, 2015

It would be helpful to log pool growth and shrinkage events at a more prominent log level, e.g. INFO or WARN, to facilitate performance tuning.

dfish3r added a commit that referenced this issue Sep 4, 2015

Increase pool log levels.
Log connection create and remove at info.
See #19.

@dfish3r dfish3r closed this Sep 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment