New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLSSocketFactory#hostnameVerifier #52

Closed
dfish3r opened this Issue Jul 30, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@dfish3r
Copy link
Member

dfish3r commented Jul 30, 2015

The use case for this functionality was testing of the DefaultHostnameVerifier.
It is not used by any of the project internals and it does not work for #createSocket() since the socket is not yet opened when getSession() is invoked.
Since the behavior of SSLSocket#getPeerHost has become unreliable in the most recent Java update. [1], remove this functionality.

[1] http://shibboleth.1660669.n2.nabble.com/Shib-IdP-Metadata-Download-and-Java-1-7-0-85-td7617478.html

@dfish3r dfish3r closed this in dd156be Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment