New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request to support Durations #58

Closed
tomzeller opened this Issue Nov 25, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@tomzeller
Copy link

tomzeller commented Nov 25, 2015

Hi, how about a feature request for ldaptive to support Durations ?

"blockWaitTime in IdPv3 ldap.properties"
http://shibboleth.net/pipermail/users/2015-November/025164.html

"Incorrect idp.pool.LDAP.validatePeriod property format"
http://shibboleth.net/pipermail/users/2015-November/025528.html

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Dec 1, 2015

The Duration annotation lives in the java-support project. That would give ldaptive a dependency on an external library that doesn't exist in maven central.

Is there another annotation, perhaps in the javase, that could be used?

@mmoayyed

This comment has been minimized.

Copy link
Contributor

mmoayyed commented Dec 1, 2015

Would @SiZe work? Most Durations I know of are concrete classes, and live in the javax caching API or in JDK8. JDK8 probably is the best option, but that does require, well, JDK8 :)

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Dec 1, 2015

I'm planning to move to JDK8 very soon.

@mmoayyed

This comment has been minimized.

Copy link
Contributor

mmoayyed commented Dec 1, 2015

Good on you :) Possible timeline?

@dfish3r

This comment has been minimized.

Copy link
Member

dfish3r commented Mar 8, 2016

Resolved in merge #77

@dfish3r dfish3r closed this Mar 8, 2016

@tomzeller

This comment has been minimized.

Copy link

tomzeller commented Mar 8, 2016

Nice !

I don't think there is a related issue for the Shibboleth IdP to incorporate this, is that something you can handle too Daniel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment