Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add german CharacterData/SequenceData #108

Merged
merged 1 commit into from Jan 13, 2020

Conversation

t0rbn
Copy link
Contributor

@t0rbn t0rbn commented Dec 23, 2019

  • add german language data
  • extract language data to separate packages

@dfish3r
Copy link
Member

@dfish3r dfish3r commented Dec 24, 2019

I don't think we have enough language specific classes to need a separate package yet. Also, rearranging the packages is an API breaking change. I'd prefer to include your patch without that much disruption. Can you resubmit this patch without the package changes? Thanks.

@t0rbn t0rbn force-pushed the german-language-data branch from 115d41b to 8d0ec07 Compare Dec 24, 2019
@t0rbn
Copy link
Contributor Author

@t0rbn t0rbn commented Dec 24, 2019

sure, I already had a hunch that screwing with the package structure might break things

@dfish3r dfish3r merged commit 5080f32 into vt-middleware:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants