Added keyboard sequence for german QWERTZ layout. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! I will rename the enum as the prefix is intended to match the keyboard layout for the country. Admittedly I'm not sure what the prefix for the Swiss layout would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the keyboard sequence for the standard german keyboard layout, where y and z (and some other special characters) are placed differently compared to the english layout. I did not copy the full tests, that are made for USQwerty, but this is not necessary - the functionality does not depend on the layout itself.
I was unsure about the naming - you may also name the enum entry "DEQwertz", if the focus is on ISO country codes and not language codes. "DE" would be the correct ISO 3166 Alpha-2 country code for Germany. In the long run, this would be correct, because e.g. Switzerland has a slightly different keyboard layout, than Germany.