New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceRule refactoring. #23

Merged
merged 1 commit into from Dec 1, 2014

Conversation

Projects
None yet
2 participants
@serac
Copy link
Member

serac commented Oct 20, 2014

  1. Rename SequenceRule->IllegalSequenceRule for consistency with other
    rules that have negative semantics.
  2. Rename SequenceData->IllegalSequenceData for consistency.
  3. Add IllegalSequence type to describe sequences (e.g. differing case,
    variant forms).
  4. Create EnIllegalSequenceData enum with common sequences (alpha, numeric,
    keyboard).
SequenceRule refactoring.
1. Rename SequenceRule->IllegalSequenceRule for consistency with other
   rules that have negative semantics.
2. Rename SequenceData->IllegalSequenceData for consistency.
3. Add IllegalSequence type to describe sequences (e.g. differing case,
   variant forms).
4. Create EnIllegalSequenceData enum with common sequences (alpha, numeric,
   keyboard).
@serac

This comment has been minimized.

I'll admit I'm not crazy about this name. Open to suggestions.

{
return this.original.length();
}
}

This comment has been minimized.

@dfish3r

dfish3r Oct 21, 2014

Member

I would call this class 'Sequence', there's nothing inherently illegal about it. It may have other uses outside of the IllegalSequenceRule.
I don't find the term original or variant to be meaningful and I don't think providing these as Strings versus char[][] provides any more clarity.

This comment has been minimized.

@serac

serac Oct 21, 2014

Member

I would call this class 'Sequence'

Fair enough

I don't find the term original or variant to be meaningful and I don't think providing these as Strings versus char[][] provides any more clarity.

Agree on the naming feedback, but the use of Strings goes much farther than simply character specification. The use of the IllegalSequence class clarified if not simplified the implementation of IllegalSequenceRule.

This comment has been minimized.

@dfish3r

dfish3r Oct 21, 2014

Member

Agreed, FWIW I don't think char[][] is any clearer. It's a wash.

{
return sequences;
}
}

This comment has been minimized.

@dfish3r

dfish3r Oct 21, 2014

Member

Drop the 'En' prefix. I don't think it's necessary since we are only going to provide 'En' characters by default.

* @return one or more illegal character sequences.
*/
IllegalSequence[] getSequences();
}

This comment has been minimized.

@dfish3r

dfish3r Oct 21, 2014

Member

Rename this interface SequenceData. It may have reuse value outside of the IllegalSequenceRule.

@serac

This comment has been minimized.

Copy link
Member

serac commented Dec 1, 2014

These changes got merged with #22.

@serac serac closed this Dec 1, 2014

@serac serac reopened this Dec 1, 2014

serac added a commit that referenced this pull request Dec 1, 2014

@serac serac merged commit b9ace8e into vt-middleware:international Dec 1, 2014

@serac serac deleted the serac:character-sequence-data-enum branch Dec 1, 2014

@serac

This comment has been minimized.

Copy link
Member

serac commented Dec 1, 2014

I will address the suggestions you made above on the international branch.

serac added a commit that referenced this pull request Dec 1, 2014

Name and impl cleanup.
Name changes as inspired by discussion on #23.

serac added a commit that referenced this pull request Dec 1, 2014

Name and impl cleanup.
Name changes as inspired by discussion on #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment