Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return only one result for HistoryRule #68

Closed

Conversation

@ambrusadrianz
Copy link

@ambrusadrianz ambrusadrianz commented Dec 11, 2017

If the password history contains multiple entries that the new password matches to, the result contains two identical result details.

In normal situtations (when using password history rule from the beginning) this wouldn't happen. But in case if a password history check is introduced later on, a result could appear multiple times, as many times as the new password matched the history entries.

This change should make the result a bit more opaque.

Thank you for making this library, it's really useful 馃憤

dfish3r added a commit that referenced this pull request Dec 11, 2017
We have a convention of using reportAllFailures controlling whether a rule only reports the first failure or all failures.
This PR adds that property to both the HistoryRule and SourceRule.
Note that this changes the default behavior, but this is probably the desired behavior.
See PR #68.
@dfish3r
Copy link
Member

@dfish3r dfish3r commented Dec 12, 2017

This should be fixed now on a separate pull request.
new HistoryRule(false) would only report the first history match.

@dfish3r dfish3r closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants