Fix NoSuchMethodErrors using Buffer when compiling on JDK9+#98
Merged
dfish3r merged 2 commits intovt-middleware:masterfrom Apr 10, 2019
Merged
Fix NoSuchMethodErrors using Buffer when compiling on JDK9+#98dfish3r merged 2 commits intovt-middleware:masterfrom
dfish3r merged 2 commits intovt-middleware:masterfrom
Conversation
Contributor
Author
|
btw, why isn't github running the travis build on every push? I guess it needs to be set up. |
Member
|
The travis build only runs against master. |
Member
|
Thanks for this patch. I'll test it against our Java8 projects shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and running on JDK 8.
I see you just reverted the JDK upgrade due to these Buffer API changes causing trouble... I hope this fixes it and you can proceed with the upgrade. Would be a shame to be stuck on JDK8...
btw, to recreate the issue without this fix, build (mvn clean install) using JDK 9+ (just specify a JAVA_HOME pointing to it), and then run the tests without compiling (mvn surefire:test) using JDK8.