From 7d4d4be53222afeecbe2d23e6a043f1514392e65 Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Mon, 2 Mar 2020 14:53:28 -0300 Subject: [PATCH 1/8] use new installment criteria in products query --- CHANGELOG.md | 3 +++ messages/context.json | 12 +++++++++++- messages/en.json | 12 +++++++++++- messages/es.json | 12 +++++++++++- messages/pt.json | 12 +++++++++++- react/ProductSummaryList.js | 27 ++++++++++++++++++++++++++- 6 files changed, 73 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 38133e9d..d9e53564 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Added +- `ProductSummaryList`: `installmentCriteeria` prop to use in `products` query. +- `ProductSummaryList`: Messages and translations to be able to edit `skusFilter` and `installmentCriteria` in site editor. ## [2.51.7] - 2020-03-02 ### Changed diff --git a/messages/context.json b/messages/context.json index 06bae374..2426fa4c 100644 --- a/messages/context.json +++ b/messages/context.json @@ -54,5 +54,15 @@ "admin/editor.productSummaryList.orderType.nameDesc": "Name, descending", "admin/editor.productSummaryList.orderType.releaseDate": "Release Date", "admin/editor.productSummaryList.orderType.discount": "Discount", - "admin/editor.productSummaryList.orderType.relevance": "Relevance" + "admin/editor.productSummaryList.orderType.relevance": "Relevance", + "admin/editor.productSummaryList.skusFilter.title": "Title of skus filter property", + "admin/editor.productSummaryList.skusFilter.description": "Description of skus filter property", + "admin/editor.productSummaryList.skusFilter.none": "Value none of skus filter enum", + "admin/editor.productSummaryList.skusFilter.first-available": "Value first available of skus filter enum", + "admin/editor.productSummaryList.skusFilter.all-available": "Value all available of skus filter enum", + "admin/editor.productSummaryList.installmentCriteria.title": "Title of installment criteria property", + "admin/editor.productSummaryList.installmentCriteria.description": "Description of installment criteria property", + "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Maximum without interest enum name", + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest enum name", + "admin/editor.productSummaryList.installmentCriteria.min": "Minimum enum name" } diff --git a/messages/en.json b/messages/en.json index 8b53fd3c..697196d6 100644 --- a/messages/en.json +++ b/messages/en.json @@ -54,5 +54,15 @@ "admin/editor.productSummaryList.orderType.nameDesc": "Name, descending", "admin/editor.productSummaryList.orderType.releaseDate": "Release Date", "admin/editor.productSummaryList.orderType.discount": "Discount", - "admin/editor.productSummaryList.orderType.relevance": "Relevance" + "admin/editor.productSummaryList.orderType.relevance": "Relevance", + "admin/editor.productSummaryList.skusFilter.title": "SKUs Filter", + "admin/editor.productSummaryList.skusFilter.description": "Setting the first available filter might make your query much faster!", + "admin/editor.productSummaryList.skusFilter.none": "None", + "admin/editor.productSummaryList.skusFilter.first-available": "First available", + "admin/editor.productSummaryList.skusFilter.all-available": "All available", + "admin/editor.productSummaryList.installmentCriteria.title": "Prices with Installment", + "admin/editor.productSummaryList.installmentCriteria.description": "Choose what type of prices to be showed in the products displayed (e.g.: maximum without interest or with interest, etc).", + "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Maximum without interest", + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest", + "admin/editor.productSummaryList.installmentCriteria.min": "Minimum" } diff --git a/messages/es.json b/messages/es.json index dd952c84..077da8c6 100644 --- a/messages/es.json +++ b/messages/es.json @@ -54,5 +54,15 @@ "admin/editor.productSummaryList.orderType.nameDesc": "Nombre, descendiendo", "admin/editor.productSummaryList.orderType.releaseDate": "Fecha de lanzamiento", "admin/editor.productSummaryList.orderType.discount": "Descuento", - "admin/editor.productSummaryList.orderType.relevance": "Relevancia" + "admin/editor.productSummaryList.orderType.relevance": "Relevancia", + "admin/editor.productSummaryList.skusFilter.title": "Filtro de SKUs", + "admin/editor.productSummaryList.skusFilter.description": "¡Establecer el primer iten disponible agiliza su consulta!", + "admin/editor.productSummaryList.skusFilter.none": "Ninguno", + "admin/editor.productSummaryList.skusFilter.first-available": "Primero disponible", + "admin/editor.productSummaryList.skusFilter.all-available": "Todos disponibles", + "admin/editor.productSummaryList.installmentCriteria.title": "Criterio de precio a plazos", + "admin/editor.productSummaryList.installmentCriteria.description": "Elija qué tipo de precio se mostrará en los productos (por ejemplo, máximo sin interés, o con interés, etc.)", + "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sin interés", + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo con interés", + "admin/editor.productSummaryList.installmentCriteria.min": "Mínimo" } diff --git a/messages/pt.json b/messages/pt.json index 48fa8475..c49f3f02 100644 --- a/messages/pt.json +++ b/messages/pt.json @@ -54,5 +54,15 @@ "admin/editor.productSummaryList.orderType.nameDesc": "Nome, decrescente", "admin/editor.productSummaryList.orderType.releaseDate": "Data de lançamento", "admin/editor.productSummaryList.orderType.discount": "Desconto", - "admin/editor.productSummaryList.orderType.relevance": "Relevância" + "admin/editor.productSummaryList.orderType.relevance": "Relevância", + "admin/editor.productSummaryList.skusFilter.title": "Filtro de SKUs", + "admin/editor.productSummaryList.skusFilter.description": "Configurando o valor de primeiro disponível pode fazer sua query ser mais rápida!", + "admin/editor.productSummaryList.skusFilter.none": "Nenhum", + "admin/editor.productSummaryList.skusFilter.first-available": "Primeiro Disponível", + "admin/editor.productSummaryList.skusFilter.all-available": "Todos Disponíveis", + "admin/editor.productSummaryList.installmentCriteria.title": "Preços com Parcelas", + "admin/editor.productSummaryList.installmentCriteria.description": "Escolha qual tipo de preço a ser mostrado nos produtos (ex.: máximo sem juros, ou com juros, etc).", + "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sem juros", + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo com juros", + "admin/editor.productSummaryList.installmentCriteria.min": "Mínimo" } diff --git a/react/ProductSummaryList.js b/react/ProductSummaryList.js index 974be670..2acdfa30 100644 --- a/react/ProductSummaryList.js +++ b/react/ProductSummaryList.js @@ -60,9 +60,9 @@ const ProductSummaryList = ({ specificationFilters = [], maxItems = 10, skusFilter, + installmentCriteria, }) => { const { data, loading, error } = useQuery(productsQuery, { - name: 'productList', variables: { category, ...(collection != null @@ -76,6 +76,7 @@ const ProductSummaryList = ({ to: maxItems - 1, hideUnavailableItems, skusFilter, + installmentCriteria, }, }) @@ -182,6 +183,30 @@ EnhancedProductList.getSchema = () => ({ isLayout: false, default: 10, }, + skusFilter: { + title: 'admin/editor.productSummaryList.skusFilter.title', + description: 'admin/editor.productSummaryList.skusFilter.description', + type: 'string', + default: 'ALL_AVAILABLE', + enum: ['ALL_AVAILABLE', 'ALL', 'FIRST_AVAILABLE'], + enumNames: [ + 'admin/editor.productSummaryList.skusFilter.all-available', + 'admin/editor.productSummaryList.skusFilter.none', + 'admin/editor.productSummaryList.skusFilter.first-available' + ] + }, + installmentCriteria: { + title: 'admin/editor.productSummaryList.installmentCriteria.title', + description: 'admin/editor.productSummaryList.installmentCriteria.description', + type: 'string', + default: 'MAX_WITHOUT_INTEREST', + enum: ['MAX_WITHOUT_INTEREST', 'MAX_WITH_INTEREST', 'MIN'], + enumNames: [ + 'admin/editor.productSummaryList.installmentCriteria.max-without-interest', + 'admin/editor.productSummaryList.installmentCriteria.max-with-interest', + 'admin/editor.productSummaryList.installmentCriteria.min' + ] + }, }, }) From b9fd2094db4e3fb583a16811919e52f1bf64ca62 Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Mon, 2 Mar 2020 15:04:22 -0300 Subject: [PATCH 2/8] update docs --- docs/ProductSummaryList.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/ProductSummaryList.md b/docs/ProductSummaryList.md index 5fad7c97..7cab9fcf 100644 --- a/docs/ProductSummaryList.md +++ b/docs/ProductSummaryList.md @@ -35,3 +35,21 @@ This block is used to specify what variation of `product-summary` to be used to | `orderBy` | `Enum` | Ordination type of the items. Possible values: `OrderByTopSaleDESC`, `OrderByReleaseDateDESC`, `OrderByBestDiscountDESC`, `OrderByPriceDESC`, `OrderByPriceASC`, `OrderByNameASC`, `OrderByNameDESC` | `OrderByTopSaleDESC` | | `hideUnavailableItems` | `Boolean` | Hides items that are unavailable. | `false` | | `maxItems` | `Number` | Maximum items to be fetched. | `10` | +| `skusFilter` | `SkusFilterEnum` | Control SKUs returned for each product in the query. The less SKUs needed to be returned, the more performant your shelf query will be. | `"ALL_AVAILABLE"` | +| `installmentCriteria` | `InstallmentCriteriaEnum` | ControlControl what pricee to be shown when price has different installments options. | `"MAX_WITHOUT_INTEREST"` | + +For `SkusFilterEnum`: + +| Name | Value | Description | +| ---- | ----- | ----------- | +| First Available | `FIRST_AVAILABLE` | Most performant, ideal if you do not have a SKU selector in your shelf. Will return only the first available SKU for that product in your shelf query. | +| All Available | `ALL_AVAILABLE` | A bit better performace, will only return SKUs that are available, ideal if you have a SKU selector but still want a better performance. | +| All | `ALL` | Returns all SKUs related to that product, least performant option. | + +For `InstallmentCriteriaEnum`: + +| Name | Value | Description | +| ---- | ----- | ----------- | +| Maximum without interest | `MAX_WITHOUT_INTEREST` | Will display price with maximum value before interest. | +| Maximum with interest | `MAX_WITH_INTEREST` | Will display price with maximum value after interest applied. | +| Minimum | `MIN` | Will display the lowest price before interest. | From 6ecd43162bb640cdc3b1b66267213f7dfa0a887e Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Mon, 2 Mar 2020 15:04:58 -0300 Subject: [PATCH 3/8] fix typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9e53564..23b56c9d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] ### Added -- `ProductSummaryList`: `installmentCriteeria` prop to use in `products` query. +- `ProductSummaryList`: `installmentCriteria` prop to use in `products` query. - `ProductSummaryList`: Messages and translations to be able to edit `skusFilter` and `installmentCriteria` in site editor. ## [2.51.7] - 2020-03-02 From 018197c1cf89690bf6ca77102750cefbc44b91be Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Tue, 3 Mar 2020 10:09:34 -0300 Subject: [PATCH 4/8] remove minimum element --- docs/ProductSummaryList.md | 1 - messages/context.json | 3 +-- messages/en.json | 3 +-- messages/es.json | 3 +-- messages/pt.json | 3 +-- react/ProductSummaryList.js | 3 +-- 6 files changed, 5 insertions(+), 11 deletions(-) diff --git a/docs/ProductSummaryList.md b/docs/ProductSummaryList.md index 7cab9fcf..b8048718 100644 --- a/docs/ProductSummaryList.md +++ b/docs/ProductSummaryList.md @@ -52,4 +52,3 @@ For `InstallmentCriteriaEnum`: | ---- | ----- | ----------- | | Maximum without interest | `MAX_WITHOUT_INTEREST` | Will display price with maximum value before interest. | | Maximum with interest | `MAX_WITH_INTEREST` | Will display price with maximum value after interest applied. | -| Minimum | `MIN` | Will display the lowest price before interest. | diff --git a/messages/context.json b/messages/context.json index 2426fa4c..6ad03979 100644 --- a/messages/context.json +++ b/messages/context.json @@ -63,6 +63,5 @@ "admin/editor.productSummaryList.installmentCriteria.title": "Title of installment criteria property", "admin/editor.productSummaryList.installmentCriteria.description": "Description of installment criteria property", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Maximum without interest enum name", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest enum name", - "admin/editor.productSummaryList.installmentCriteria.min": "Minimum enum name" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest enum name" } diff --git a/messages/en.json b/messages/en.json index 697196d6..56316c5e 100644 --- a/messages/en.json +++ b/messages/en.json @@ -63,6 +63,5 @@ "admin/editor.productSummaryList.installmentCriteria.title": "Prices with Installment", "admin/editor.productSummaryList.installmentCriteria.description": "Choose what type of prices to be showed in the products displayed (e.g.: maximum without interest or with interest, etc).", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Maximum without interest", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest", - "admin/editor.productSummaryList.installmentCriteria.min": "Minimum" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest" } diff --git a/messages/es.json b/messages/es.json index 077da8c6..d34d12be 100644 --- a/messages/es.json +++ b/messages/es.json @@ -63,6 +63,5 @@ "admin/editor.productSummaryList.installmentCriteria.title": "Criterio de precio a plazos", "admin/editor.productSummaryList.installmentCriteria.description": "Elija qué tipo de precio se mostrará en los productos (por ejemplo, máximo sin interés, o con interés, etc.)", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sin interés", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo con interés", - "admin/editor.productSummaryList.installmentCriteria.min": "Mínimo" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo con interés" } diff --git a/messages/pt.json b/messages/pt.json index c49f3f02..7d7cb9aa 100644 --- a/messages/pt.json +++ b/messages/pt.json @@ -63,6 +63,5 @@ "admin/editor.productSummaryList.installmentCriteria.title": "Preços com Parcelas", "admin/editor.productSummaryList.installmentCriteria.description": "Escolha qual tipo de preço a ser mostrado nos produtos (ex.: máximo sem juros, ou com juros, etc).", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sem juros", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo com juros", - "admin/editor.productSummaryList.installmentCriteria.min": "Mínimo" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo com juros" } diff --git a/react/ProductSummaryList.js b/react/ProductSummaryList.js index 2acdfa30..ac231c04 100644 --- a/react/ProductSummaryList.js +++ b/react/ProductSummaryList.js @@ -203,8 +203,7 @@ EnhancedProductList.getSchema = () => ({ enum: ['MAX_WITHOUT_INTEREST', 'MAX_WITH_INTEREST', 'MIN'], enumNames: [ 'admin/editor.productSummaryList.installmentCriteria.max-without-interest', - 'admin/editor.productSummaryList.installmentCriteria.max-with-interest', - 'admin/editor.productSummaryList.installmentCriteria.min' + 'admin/editor.productSummaryList.installmentCriteria.max-with-interest' ] }, }, From 63806f198dd10f147286c3ed7fce810beea18514 Mon Sep 17 00:00:00 2001 From: Breno Calazans Date: Tue, 3 Mar 2020 10:19:12 -0300 Subject: [PATCH 5/8] Update docs/ProductSummaryList.md --- docs/ProductSummaryList.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ProductSummaryList.md b/docs/ProductSummaryList.md index b8048718..82e1ca87 100644 --- a/docs/ProductSummaryList.md +++ b/docs/ProductSummaryList.md @@ -36,7 +36,7 @@ This block is used to specify what variation of `product-summary` to be used to | `hideUnavailableItems` | `Boolean` | Hides items that are unavailable. | `false` | | `maxItems` | `Number` | Maximum items to be fetched. | `10` | | `skusFilter` | `SkusFilterEnum` | Control SKUs returned for each product in the query. The less SKUs needed to be returned, the more performant your shelf query will be. | `"ALL_AVAILABLE"` | -| `installmentCriteria` | `InstallmentCriteriaEnum` | ControlControl what pricee to be shown when price has different installments options. | `"MAX_WITHOUT_INTEREST"` | +| `installmentCriteria` | `InstallmentCriteriaEnum` | ControlControl what price to be shown when price has different installments options. | `"MAX_WITHOUT_INTEREST"` | For `SkusFilterEnum`: From 8a902885c946e9796a7d977c29c5025b3975c3e6 Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Tue, 3 Mar 2020 11:07:58 -0300 Subject: [PATCH 6/8] use better words --- docs/ProductSummaryList.md | 4 ++-- messages/en.json | 6 +++--- messages/es.json | 6 +++--- messages/pt.json | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/ProductSummaryList.md b/docs/ProductSummaryList.md index 82e1ca87..dabf348f 100644 --- a/docs/ProductSummaryList.md +++ b/docs/ProductSummaryList.md @@ -50,5 +50,5 @@ For `InstallmentCriteriaEnum`: | Name | Value | Description | | ---- | ----- | ----------- | -| Maximum without interest | `MAX_WITHOUT_INTEREST` | Will display price with maximum value before interest. | -| Maximum with interest | `MAX_WITH_INTEREST` | Will display price with maximum value after interest applied. | +| Maximum without interest | `MAX_WITHOUT_INTEREST` | Will display the maximum installment option with no interest. | +| Maximum | `MAX_WITH_INTEREST` | Will display the maximum installment option having interest or not. | diff --git a/messages/en.json b/messages/en.json index 56316c5e..c6af9823 100644 --- a/messages/en.json +++ b/messages/en.json @@ -60,8 +60,8 @@ "admin/editor.productSummaryList.skusFilter.none": "None", "admin/editor.productSummaryList.skusFilter.first-available": "First available", "admin/editor.productSummaryList.skusFilter.all-available": "All available", - "admin/editor.productSummaryList.installmentCriteria.title": "Prices with Installment", - "admin/editor.productSummaryList.installmentCriteria.description": "Choose what type of prices to be showed in the products displayed (e.g.: maximum without interest or with interest, etc).", + "admin/editor.productSummaryList.installmentCriteria.title": "Displayed installments", + "admin/editor.productSummaryList.installmentCriteria.description": "Choose what type of installments to be showed (e.g.: maximum without interest or with interest).", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Maximum without interest", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum with interest" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Maximum" } diff --git a/messages/es.json b/messages/es.json index d34d12be..46fe7c89 100644 --- a/messages/es.json +++ b/messages/es.json @@ -60,8 +60,8 @@ "admin/editor.productSummaryList.skusFilter.none": "Ninguno", "admin/editor.productSummaryList.skusFilter.first-available": "Primero disponible", "admin/editor.productSummaryList.skusFilter.all-available": "Todos disponibles", - "admin/editor.productSummaryList.installmentCriteria.title": "Criterio de precio a plazos", - "admin/editor.productSummaryList.installmentCriteria.description": "Elija qué tipo de precio se mostrará en los productos (por ejemplo, máximo sin interés, o con interés, etc.)", + "admin/editor.productSummaryList.installmentCriteria.title": "Criterio de cuotas", + "admin/editor.productSummaryList.installmentCriteria.description": "Elija qué tipo de cuota se mostrará en los productos (p. Ej., Máximo sin interés o con interés).", "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sin interés", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo con interés" + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo" } diff --git a/messages/pt.json b/messages/pt.json index 7d7cb9aa..de85e56a 100644 --- a/messages/pt.json +++ b/messages/pt.json @@ -60,8 +60,8 @@ "admin/editor.productSummaryList.skusFilter.none": "Nenhum", "admin/editor.productSummaryList.skusFilter.first-available": "Primeiro Disponível", "admin/editor.productSummaryList.skusFilter.all-available": "Todos Disponíveis", - "admin/editor.productSummaryList.installmentCriteria.title": "Preços com Parcelas", - "admin/editor.productSummaryList.installmentCriteria.description": "Escolha qual tipo de preço a ser mostrado nos produtos (ex.: máximo sem juros, ou com juros, etc).", - "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máximo sem juros", - "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máximo com juros" + "admin/editor.productSummaryList.installmentCriteria.title": "Parcelamento", + "admin/editor.productSummaryList.installmentCriteria.description": "Escolha qual tipo de parcelamento a ser mostrado nos produtos (ex.: máximo sem juros, ou com juros).", + "admin/editor.productSummaryList.installmentCriteria.max-without-interest": "Máxima sem juros", + "admin/editor.productSummaryList.installmentCriteria.max-with-interest": "Máxima" } From 20e606fcda46f3663aa11cbb1afec2cbd5967044 Mon Sep 17 00:00:00 2001 From: Breno Calazans Date: Tue, 3 Mar 2020 14:57:54 -0300 Subject: [PATCH 7/8] Fix props passed to ProductSummaryList --- CHANGELOG.md | 3 +++ react/ProductSummaryList.js | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 23b56c9d..0fc00772 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - `ProductSummaryList`: `installmentCriteria` prop to use in `products` query. - `ProductSummaryList`: Messages and translations to be able to edit `skusFilter` and `installmentCriteria` in site editor. +### Fixed +- Props passed to `ProductSummaryList` + ## [2.51.7] - 2020-03-02 ### Changed - `ProductSummaryList`: Consume new products query. diff --git a/react/ProductSummaryList.js b/react/ProductSummaryList.js index ac231c04..d50a7239 100644 --- a/react/ProductSummaryList.js +++ b/react/ProductSummaryList.js @@ -115,12 +115,12 @@ const ProductSummaryList = ({ ) } -const EnhancedProductList = ({ children }) => { +const EnhancedProductList = ({ children, ...props }) => { const { ProductListProvider } = ProductListContext return ( - {children} + {children} ) From 135d336205c32f9eb6e48326f0c5c2893a10e9c8 Mon Sep 17 00:00:00 2001 From: Joao Fidelis Date: Tue, 3 Mar 2020 15:02:51 -0300 Subject: [PATCH 8/8] remove min value from enums --- react/ProductSummaryList.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react/ProductSummaryList.js b/react/ProductSummaryList.js index d50a7239..173c6c05 100644 --- a/react/ProductSummaryList.js +++ b/react/ProductSummaryList.js @@ -200,7 +200,7 @@ EnhancedProductList.getSchema = () => ({ description: 'admin/editor.productSummaryList.installmentCriteria.description', type: 'string', default: 'MAX_WITHOUT_INTEREST', - enum: ['MAX_WITHOUT_INTEREST', 'MAX_WITH_INTEREST', 'MIN'], + enum: ['MAX_WITHOUT_INTEREST', 'MAX_WITH_INTEREST'], enumNames: [ 'admin/editor.productSummaryList.installmentCriteria.max-without-interest', 'admin/editor.productSummaryList.installmentCriteria.max-with-interest'